Repository navigation
fix(server): generate titles with the default provider - #194
Merged
Merged
Conversation
GoDiao
approved these changes
Oct 27, 2026
GoDiao
left a comment
Owner
There was a problem hiding this comment.
Thanks @UnrealHenry, and welcome! This is exactly the fix #193 suggested: null now falls back to the active provider the same way chat does, the outdated comment is gone, and the new test checks both the title and the model the request used. Thanks also for comparing the Windows test failures against a clean main, that saved us a round trip.
Approving and merging. If you find DreamCoder useful, a ⭐ on the repo would mean a lot to us. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An effort-only runtime selection stores a null provider and an empty model. Chat follows the active provider, but title generation returned before attempting the same fallback, leaving the session's placeholder title in place.
Allow the existing active-provider lookup to handle null, add an isolated loopback regression test that checks the selected model and returned title, and remove the obsolete comment about null providers in the chat resolver.
Closes #193.
Validation on Windows with Bun 1.3.13:
bun test ./src/server/__tests__/title-service.test.ts: 15 passed.bun test --randomize --seed=1 ./src/server/__tests__/title-service.test.ts: 15 passed.bun run lint: passed.bun run test -- --run: 125 files passed, 1320 tests passed, 4 skipped.bun test: 1384 passed, 17 skipped, 35 failed. A separate pristinemainworktree at70b8321has 1383 passed, 17 skipped, and the exact same 35 failing test names. These failures include shell/PATH, symlink, platform and config-directory scan behavior in this Windows environment. CI pins Bun 1.4.2; that version was not run locally.This contribution was prepared and tested with Codex assistance.