Repository navigation
fix(server): log why AI title generation failed - #192
Merged
GoDiao merged 1 commit intoOct 26, 2026
Merged
Conversation
Fixes GoDiao#176 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
GoDiao
approved these changes
Oct 26, 2026
GoDiao
left a comment
Owner
There was a problem hiding this comment.
Thanks @pcbeingused333, this is exactly what #176 asked for! One line per failed attempt with the session, provider, model and reason, the empty catch gone, and the return value unchanged. We checked that the three new tests fail on main and that they restore console.warn and stop their servers.
Approving. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176
generateTitlereturnednullwithout a trace for several different causes, so a session that kept its placeholder title gave no hint why. It now logs oneconsole.warnline per failed attempt with the session id, the provider id, the model and the reason:catchThe return value and the placeholder title behave as before.
generateTitletakes an optionalsessionIdfor the log line; the WebSocket handler passes it.Tests in
title-service.test.tscover an upstream 400, a non-title reply and a missing provider; they fail without the change.bun testfor that file andtsc --noEmitpass.This change was prepared with Claude Code (AI-assisted); the tests above were run.
🤖 Generated with Claude Code