Repository navigation
ci(release): unset empty signing secrets before electron-builder - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.8.0-beta.1 tag run failed in the macOS build:
The signing secrets are not set, so GitHub passes them as empty strings. electron-builder treats
CSC_LINK=""as defined and resolves it as a certificate path, which points at the working directory. Pull request runs did not catch it: electron-builder skips signing on PRs ("Current build is a part of pull request, code signing will be skipped"), and #185 and #186 only ran there.The build step now unsets every signing variable that is empty before calling electron-builder. Builds without secrets stay ad-hoc signed on macOS and unsigned on Windows. Once the secrets are set, they are passed through unchanged.
Tested: the unset loop was checked in bash (an empty variable is unset, a set one is kept). The tag path itself can only be verified by re-running the v0.8.0-beta.1 release after merge; that draft was never published.