Repository navigation
ci(smoke): create the Windows search fixture under the user profile - #182
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.7.0 Windows smoke test installed and started the app, then failed the bundled ripgrep check added in #178:
/api/filesystem/browseonly allows paths under the home directory,/tmpand registered roots. The fixture was created under$env:TEMP. On the runner the account isrunneradmin, longer than 8 characters, soTEMPis usually the 8.3 short pathC:\Users\RUNNER~1\..., which does not match the home directoryC:\Users\runneradminas a string prefix. The macOS fixture is under/tmpand passed.The fixture now lives under
$env:USERPROFILE, which is how real users reach the search (folders picked under their profile). The server's access rule is unchanged.Tested: this workflow only runs on release tags, so it is verified by re-running the v0.7.0 release after merge.