Conversation
This: - add a `filter()` instance method on `Result` to filter `ResultItem` objects - add comprehensive unit tests for common filtering scenarios
This: - add a `find()` instance method on `Result` to find first matching `ResultItem` object - add comprehensive unit tests for common find scenarios
lykmapipo
requested review from
aperdizs,
giselamo,
tomaslink and
yaaNuamahGFW
tomaslink
reviewed
Feb 10, 2026
… find This: - introduce internal `_iter_data()` helper to lazily iterate over `Result` data without copying - refactor `df()`, `filter()`, and `find()` to use unified `_iter_data()` - make `filter()` return a shallow copy when predicate is invalid or not callable - make `find()` safely return `None` for invalid predicates - add unit tests covering invalid predicate handling and edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
find()method onResultto return the first matchingResultItemfilter()method onResultto return matchingResultItemobjects