Remove obsolete Java/Python local-source suites superseded by threat-models: local#218
threat-models: local#218Conversation
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
threat-models: local
|
@copilot these CIs are failing - https://github.com/GitHubSecurityLab/CodeQL-Community-Packs/actions/runs/31428133394/job/95480891186?pr=218 Is there an outage or is this something we impacted in this change? |
Upstream, not something this PR's diff caused. Both jobs fail in the (same signature for Those two versions were just published under CLI 2.26.3's new upload format, manifests are tagged Not a broader outage: cpp/csharp/go/javascript/ruby This will keep failing on any python/java PR until the CLI pin here moves to 2.26.3+. #220 already looks like it's prepping the |
CodeQL's built-in
threat-models: localsetting, applied to the default (non-local) queries, now provides the coverage these community-pack-localsuites were built for. Both suites were also independently non-functional.Removed suites
java/src/suites/java-local.qls: referenced an undeclaredcodeql/java-queriesdependency (unresolvable); all 12 listed upstream query IDs were deleted in CodeQL 2.17.4 anyway; its one GHSL query reference (java/xxe-local) never matched the query's actual@id(githubsecuritylab/xxe-local).python/src/suites/python-local.qls: always resolved to zero queries due to a YAML bug:Config
configs/synthetics.yml: dropped the two-localsuite entries.threat-models: localstays, since it's the mechanism now providing equivalent coverage on the default (non-suffixed) queries.Versioning
java/src/qlpack.ymlandpython/src/qlpack.yml(0.7.5→0.8.0), since a named, externally-referenceable suite is being removed from each pack.Out of scope
The individual
*Local.qlqueries andLocalSources.qll/XMLLocalLib.qlllibraries are untouched. They already run via the defaultjava.qls/python.qlssuites regardless of the removed suites, and GHSL's local-source libraries cover some file-read sources (e.g.pickle,pandas,yaml) beyond upstream's "file" threat model, so removing them isn't a pure no-op. Left as a separate follow-up if desired.localpacks with new configurablethreat-modelssetting in CodeQL #69