Open
Conversation
|
Since this Pull Request originated from a forked repository, Now cannot deploy it as there are potential security risks. If you are a collaborator on this repository, consider making this Pull Request from a branch on the same repository instead of a fork. |
Author
|
yes @0x48piraj !! |
bogas04
requested changes
Jul 9, 2018
Collaborator
There was a problem hiding this comment.
Could you rename file as AddToCart and change class name to the same? This type of casing is called capitalized camel casing.
- camelCase (for variable names, methods, functions)
- CapCase (for ClassNames)
- CAPITALIZED_SNAKE_CASE (for constants)
- snake_case (not recommended in Java/JavaScript however quite popular in PHP/Python/C).
Also please use prettier to fix formatting issues. You can install the extension in VSCode as mentioned in project README.md file. Let us know if you face difficulties.
addtocart/cartbutton.js
Outdated
| <style jsx>{` | ||
| button { | ||
| * | ||
| * |
addtocart/cartbutton.js
Outdated
| * | ||
| * | ||
| * | ||
| background-color: #e33812; font-size: 16px; |
Collaborator
There was a problem hiding this comment.
Could you place font-size to new line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.