feat(samples): ios 27 support - #1286
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe iOS apps adopt Flutter’s implicit engine lifecycle, move plugin and method-channel setup into engine initialization, add single-scene manifests, enforce an iOS 15 deployment target, update ChangesiOS lifecycle and build updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant AppDelegate
participant FlutterImplicitEngineBridge
participant GeneratedPluginRegistrant
AppDelegate->>FlutterImplicitEngineBridge: didInitializeImplicitFlutterEngine
FlutterImplicitEngineBridge->>GeneratedPluginRegistrant: register plugins with pluginRegistry
FlutterImplicitEngineBridge->>AppDelegate: provide registrar messenger
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/app-distribute.yml (1)
69-69: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPin the tested Xcode 27 version.
latestchanges the archive toolchain without a repository change; hosted runner images replace prior Xcode patch releases. Pin the exact Xcode 27 build used for TestFlight build 286. (github.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/app-distribute.yml at line 69, Update the xcode-version setting in the app distribution workflow from "latest" to the exact tested Xcode 27 build used for TestFlight build 286, preserving the existing workflow structure.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/app-distribute.yml:
- Line 69: Update the xcode-version setting in the app distribution workflow
from "latest" to the exact tested Xcode 27 build used for TestFlight build 286,
preserving the existing workflow structure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 19ad50e2-69e7-491f-b453-a4e503abe70c
⛔ Files ignored due to path filters (1)
pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (11)
.github/workflows/app-distribute.ymldogfooding/ios/Podfiledogfooding/ios/Runner/AppDelegate.swiftdogfooding/ios/Runner/Info.plistdogfooding/pubspec.yamlpackages/stream_video_flutter/example/ios/Runner/AppDelegate.swiftpackages/stream_video_flutter/example/ios/Runner/Info.plistpackages/stream_video_noise_cancellation/example/ios/Runner/AppDelegate.swiftpackages/stream_video_noise_cancellation/example/ios/Runner/Info.plistpackages/stream_video_push_notification/example/ios/Runner/AppDelegate.swiftpackages/stream_video_push_notification/example/ios/Runner/Info.plist
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
==========================================
- Coverage 11.17% 11.10% -0.08%
==========================================
Files 686 686
Lines 50350 50350
==========================================
- Hits 5628 5591 -37
- Misses 44722 44759 +37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
🎯 Goal
Compiling dogfooding with latest iOS 27 build.
🛠 Implementation details
Main issue was UIScene migration that was not done in dogfooding app yet: https://docs.flutter.dev/release/breaking-changes/uiscenedelegate
🎨 UI Changes
No UI changes
🧪 Testing
Successful app build: https://github.com/GetStream/stream-video-flutter/actions/runs/29922287294/job/88930505731
Build 2.4.2 (286) in testflight.
☑️Contributor Checklist
General
☑️Reviewer Checklist
Summary by CodeRabbit