Bump Compose BOM and Paparazzi, drop the snapshot diff threshold, re-record goldens - #1795
Draft
andremion wants to merge 1 commit into
Conversation
…e-record goldens - androidxComposeBom 2024.11.00 -> 2025.08.01 and paparazzi 1.3.4 -> 1.3.5, matching the chat SDK. - Remove MAX_PERCENT_DIFFERENCE: the 0.5 threshold only existed because Paparazzi 1.3.4 antialiased fonts differently between macOS (recording) and Linux (CI verification). Paparazzi now runs with its default threshold. - Re-record all 159 goldens. Paparazzi 1.3.5 names snapshot files with underscores instead of spaces, so every file is deleted and re-added. The new images are pixel-identical to the old ones; the BOM bump caused no visual change.
Contributor
Author
|
@coderabbitai review |
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
✅ Action performedReview finished.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (161)
📒 Files selected for processing (27)
💤 Files with no reviewable changes (25)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe pull request updates Compose and Paparazzi versions, refreshes a generated API accessor name, and removes the shared custom Paparazzi difference threshold from Compose snapshot tests. ChangesCompose and Paparazzi updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR updates Compose and Paparazzi versions, removes a platform-specific snapshot threshold, and refreshes snapshot filenames without reported UI changes; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description provides clear Goal, Implementation, UI Changes, and Testing sections. It explains the dependency updates, snapshot changes, validation results, and stacked-PR dependency. The contributor and reviewer checklists and GIF section are omitted, but the core description is complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Prepare the develop-v2 build for the design refresh (AND-1472). We bump the Compose BOM and Paparazzi to the versions the chat SDK runs, drop the platform diff threshold, and re-record the snapshot goldens once, before the redesign starts. This way the redesign's snapshot diffs stay purely about design.
Stacked on #1790 (develop into develop-v2 merge-down). Do not merge before #1790; after it merges this PR will be retargeted to
develop-v2.Implementation
androidxComposeBom2024.11.00 to 2025.08.01 andpaparazzi1.3.4 to 1.3.5, matching the chat SDK exactly (chat also runs this stack on compileSdk 35).MAX_PERCENT_DIFFERENCEfromPaparazziComposeTest.ktand themaxPercentDifferenceargument from all 25 snapshot test classes. The 0.5 threshold only existed because Paparazzi 1.3.4 antialiased fonts differently between macOS (recording) and Linux (CI verification). Paparazzi now runs with its default threshold.apiDump: one syntheticComposableSingletonslambda hash changed in the ui-compose api file. This is a Compose compiler artifact of the version bump, not a real API change.🎨 UI Changes
None. All 159 re-recorded goldens are pixel-identical to the previous ones (verified with a per-pixel comparison, and confirmed by git detecting them as 100% renames).
Testing
:stream-video-android-ui-compose:recordPaparazziDebuggreen.:stream-video-android-ui-compose:verifyPaparazziDebuggreen locally (macOS) with the default threshold.spotlessCheckandapiCheckgreen.Summary by CodeRabbit
Maintenance
Tests