fix(llc): report correct X-Stream-Client header values - #125
Merged
VelikovPetar merged 1 commit intoAug 26, 2026
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 85.56% 85.57%
=======================================
Files 124 124
Lines 4364 4366 +2
=======================================
+ Hits 3734 3736 +2
Misses 630 630 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
VelikovPetar
force-pushed
the
petarvelikov/flu-734-fix-the-x-stream-client-header-values-reported-by-the-feeds
branch
from
August 25, 2026 15:15
3f4074d to
1f1f1f7
Compare
VelikovPetar
marked this pull request as ready for review
August 25, 2026 19:02
xsahil03x
approved these changes
Aug 26, 2026
VelikovPetar
deleted the
petarvelikov/flu-734-fix-the-x-stream-client-header-values-reported-by-the-feeds
branch
August 26, 2026 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
Closes FLU-734
Closes #
CLA
Description of the pull request
The SDK was sending
X-Stream-Client: stream-feeds-dart-dart-v0.3.0. Three defects, all in the environment baseline infeeds_client_impl.dart, which still carried a// TODO: Fill this with correct values:sdkNamealready carrieddart, and the format is{sdkName}-{sdkIdentifier}-v{sdkVersion}stream-feeds-dart-dart-stream-feeds-dart-v0.3.0v0.5.1, derived frompubspec.yamlosNamenever set, so noos=segment at allos=androidWhy it matters
These fields are how Stream attributes API traffic to an SDK and version. Feeds traffic was being attributed to a client string matching no real release, so a report of "Feeds Flutter 0.3.0" couldn't be correlated with anything — bad for usage analytics and for support triage.
It's also a prerequisite for FLU-727, which locks
sdkName,sdkVersionandosNameto whatever the SDK passes at construction. The baseline has to be right first, or that guard would permanently pinos=off and freeze the stale version.Changes
sdkName→stream-feeds, matching the other Feeds SDKs.sdkName/sdkIdentifierextracted as constants.sdkVersion→ a generatedpackageVersionconstant.tools/generate_version.dartderives it frompubspec.yamland runs on everymelos bootstrapviacommand.bootstrap.hooks.post, so it can't drift again. Same approach as the Chat and Video SDKs; kept deliberately close to Chat's script, minus itssample_appversion bump (Chat and Video already differ there, and Feeds' release checklist doesn't cover it).osName→CurrentPlatform.operatingSystem, so the platform is detected at runtime.updateSystemEnvironmentdartdoc — its example passedname:/version:, parameters that never existed onSystemEnvironment, so the snippet didn't compile.AGENTS.mdnotes thatlib/src/version.dartis generated and must not be hand-edited.lib/src/version.dartsits undersrc/rather thanlib/(where Chat puts it) because Feeds'lib/root holds exactly one public library, and nothing outside the package consumes the constant.Testing
dart analyze --fatal-infosanddart formatclean.9.9.9and confirmedmelos bootstrapregenerated it to0.5.1; re-running is a no-op.stream-feeds-dart-dartorv0.3.0.os=androidrather than the host'smacosconfirms runtime platform detection.No
app=/app_version=/device_model=segments appear, which is expected — those only populate when a consuming app callsupdateSystemEnvironment.Screenshots / Videos
N/A — no UI surface.