Add the duration field to the file upload responses - #58
Merged
Conversation
gpunto
force-pushed
the
upload-response-duration
branch
from
August 12, 2026 07:43
1cf3664 to
fdf8390
Compare
gpunto
force-pushed
the
upload-response-duration
branch
from
August 12, 2026 07:57
fdf8390 to
1696fd3
Compare
gpunto
marked this pull request as ready for review
August 12, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Surfaced by GetStream/stream-chat-android#6632, which switches Android's uploads to the OpenAPI-generated model.
file. In the backend OpenAPI specs,durationis the only required property ofFileUploadResponse/ImageUploadResponse—fileandthumb_urlare optional — so every client generated from them hasdurationmandatory and fails to decode the mock response (on Android:Required value 'duration' missing at $).upload_responsehelper and used it in all four routes.thumb_urlstays omitted, as the real backend omits it when no thumbnail was generated..to_s(Ruby hash-inspect, not JSON) and now use.to_json. The ~16 other.to_sbodies inendpoints.rbare a follow-up.POSTing all four routes against a local server: valid JSON withfileandduration.🧪 Testing Notes
Please verify the E2E test runs:
AttachmentsTestsincludedmainfails identically (message_list_test/reactions_test, same counts, sameRawTooltipState is a SingleTickerProviderStateMixin but multiple tickers were createdassertion). No attachment test involved and no upload decode error in the logs.