Repository navigation
fix: render the date separator above the unread indicator - #3980
Merged
Merged
Conversation
6 tasks
Contributor
SDK Size
|
isekovanic
added a commit
that referenced
this pull request
Nov 12, 2026
Ticket: https://linear.app/stream/issue/RN-527 Stacked on #3980. ## 🎯 Goal In poll creation, the + button of the max votes stepper moved when the value went from 9 to 10, because the number input grew with its text. ## 🛠 Implementation details The input gets a 32pt minimum width, no horizontal padding and centered text, so it stays the same width from 2 to 10. The row gap goes from `spacingXxs` to `spacingXs` to match the design. Vertical padding is unchanged. ## 🎨 UI Changes <details> <summary>iOS</summary> <table> <thead> <tr> <td>Before</td> <td>After</td> </tr> </thead> <tbody> <tr> <td> <!--<img src="" /> --> </td> <td> <!--<img src="" /> --> </td> </tr> </tbody> </table> </details> ## 🧪 Testing Create a poll, turn on "Multiple votes" and "Limit votes per person", and step between 9 and 10. The + button should stay in place. ## ☑️ Checklist - [ ] I have signed the [Stream CLA](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform) (required) - [ ] PR targets the `develop` branch - [ ] Documentation is updated - [ ] New code is tested in main example apps, including all possible scenarios - [ ] SampleApp iOS and Android - [ ] Expo iOS and Android
|
🎉 This PR is included in version 10.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://linear.app/stream/issue/RN-526
🎯 Goal
When the first unread message starts a new day, the unread indicator showed up above its date separator. The date separator now comes first.
🛠 Implementation details
The indicator was rendered at the bottom of the last read message's row, and the date separator at the top of the next row. It now renders in the first unread message's row, between the date separator and the message.
The selector that finds the boundary checks the previous message instead of the next one. The rule itself is unchanged.
🎨 UI Changes
iOS
🧪 Testing
Open a channel where the first unread message is on a different day than the last read one. The date separator should be above "N unread messages", with the same spacing as before.
Updated the two
MessageListtests that expected the indicator on the last read row and added one for the order.☑️ Checklist
developbranch