Repository navigation
test(e2e): run the giphy tests on Android again - #3977
Merged
Merged
Conversation
The emulator deaths in RN-513 came with -gpu swiftshader_indirect. CI has used swangle_indirect since #3965, so the giphy tests no longer need to be iOS-only. This also removes the itOnIOS helper, which only they used.
Since RN-493 a thread shows its parent message's delivery status. The parent sits outside the list's message cells, so the NIL check now looks only inside them. This fixes the in-thread ephemeral giphy test.
Reverts the temporary GiphyTests-only stress selection.
testableapple
marked this pull request as ready for review
November 12, 2026 15:26
isekovanic
self-requested a review
November 12, 2026 15:29
isekovanic
approved these changes
Nov 12, 2026
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://linear.app/stream/issue/RN-513
🎯 Goal
Run the 9
GiphyTestscases on Android again. They became iOS-only (itOnIOS) because loading giphy media sometimes took the whole Android CI emulator down.🛠 Implementation details
-gpu swiftshader_indirect. CI has used-gpu swangle_indirectsince ci(e2e): fix nightly reporting and stabilize the iOS suite #3965, and the giphy tests no longer take the emulator down with it (see Testing).GiphyTests:itOnIOS→it. This removesitOnIOS, which only these tests used, and its mentions in the e2e README and the Fastfile's test-id regex.assertMessageDeliveryStatus(NIL)now looks only inside the list's message cells. Since RN-493, a thread shows its parent message's delivery status, and the parent renders outside any cell (ThreadFooterComponent). The old whole-list check failedtest_deliveryStatusHidden_whenEphemeralMessageShownInThreadon Android every time, on the parent's ✓, not the giphy's. The same cause likely explains its occasional iOS failures (nightly 42943115860). Checks that expect a status still see the parent.🧪 Testing
GiphyTestsonly, 8 batches each, so every batch starts with a giphy test): 6 runs, 48 batches, 0 emulator losses. With SwiftShader, 1–2 of 8 batches per run lost the emulator.yarn typecheck(E2ETestApp), eslint and prettier pass on the changed files.☑️ Checklist
developbranch