fix: set the state parameter to true while querying a channel#281
Open
devinwang wants to merge 1 commit intoGetStream:masterfrom
Open
fix: set the state parameter to true while querying a channel#281devinwang wants to merge 1 commit intoGetStream:masterfrom
devinwang wants to merge 1 commit intoGetStream:masterfrom
Conversation
devinwang
requested review from
JimmyPettersson85,
akupila,
totalimmersion and
yaziine
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
Hey there,
I noticed that this Golang library doesn't assign the
truevalue to theStateparameter when the client queries channel information, which causes empty messages to be returned. I added this patch to ensure that Golang behaves the same as the NodeJS and Python libraries.Thank you!