perf(persistence): add indexes to speed up offline channel-list reads (v9)#2801
perf(persistence): add indexes to speed up offline channel-list reads (v9)#2801VelikovPetar wants to merge 2 commits into
Conversation
…t reads (v9) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v9 #2801 +/- ##
=====================================
Coverage ? 66.31%
=====================================
Files ? 429
Lines ? 27092
Branches ? 0
=====================================
Hits ? 17965
Misses ? 9127
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Submit a pull request
Linear: FLU-555
Github Issue: #
CLA
Description of the pull request
Backport of #2795 from
mastertov9.Original commit: ab20145 — perf(persistence): add SQLite indexes to speed up offline channel-list reads
Adds
@TableIndexannotations on the columns the offline read filters by:messages(channel_cid)— dominant (largest table, scanned ~30× per refresh)members(channel_cid)reads(channel_cid)reactions(message_id)Schema version bumped 30 → 31. The migration strategy on v9 is fully destructive (
createAll()on any version change), so no hand-written migration is needed — both fresh installs and upgrades pick up the indexes automatically.The
.g.dartfile was updated by adding only the indexlate finaldeclarations andallSchemaEntitieslist entries, without running a fullbuild_runnerregeneration (which would produce unrelated codegen-version diff noise on v9).Port type: Manual (schema version number differs between master and v9; all other changes applied identically).
Screenshots / Videos
No UI changes.