Skip to content

fix(core): Fix StreamChannelListController not handling notification.channel_deleted event (v9).#2800

Open
VelikovPetar wants to merge 2 commits into
v9from
port/master-to-v9/FLU-564_fix-channel-list-notification-channel-deleted
Open

fix(core): Fix StreamChannelListController not handling notification.channel_deleted event (v9).#2800
VelikovPetar wants to merge 2 commits into
v9from
port/master-to-v9/FLU-564_fix-channel-list-notification-channel-deleted

Conversation

@VelikovPetar

Copy link
Copy Markdown
Contributor

Submit a pull request

Linear: FLU-564

Github Issue: #

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Port of #2791 (commit 023687f82) from master to v9.

Adds handling for the notification.channel_deleted event in StreamChannelListController. This fixes the case where a channel is deleted but not watched — the client receives notification.channel_deleted instead of channel.deleted, so the channel was previously not removed from the list.

Also ports the expanded event-handling test suite added in the original PR.

Cherry-picked with manual conflict resolution in CHANGELOG and two refactored test bodies.

Screenshots / Videos

No UI changes.

…on.channel_deleted` event.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 19e26936-fed7-4ce5-91f5-5b3574128271

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch port/master-to-v9/FLU-564_fix-channel-list-notification-channel-deleted

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@VelikovPetar VelikovPetar changed the title fix(core): Fix StreamChannelListController not handling notification.channel_deleted event. fix(core): Fix StreamChannelListController not handling notification.channel_deleted event (v9). Jul 8, 2026
@VelikovPetar VelikovPetar marked this pull request as ready for review July 8, 2026 18:32
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v9@95c2b25). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v9    #2800   +/-   ##
=====================================
  Coverage      ?   66.57%           
=====================================
  Files         ?      429           
  Lines         ?    27093           
  Branches      ?        0           
=====================================
  Hits          ?    18036           
  Misses        ?     9057           
  Partials      ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant