fix(core): Fix StreamChannelListController not handling notification.channel_deleted event (v9).#2800
Conversation
…on.channel_deleted` event. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
StreamChannelListController not handling notification.channel_deleted event.StreamChannelListController not handling notification.channel_deleted event (v9).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v9 #2800 +/- ##
=====================================
Coverage ? 66.57%
=====================================
Files ? 429
Lines ? 27093
Branches ? 0
=====================================
Hits ? 18036
Misses ? 9057
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ification-channel-deleted
Submit a pull request
Linear: FLU-564
Github Issue: #
CLA
Description of the pull request
Port of #2791 (commit
023687f82) frommastertov9.Adds handling for the
notification.channel_deletedevent inStreamChannelListController. This fixes the case where a channel is deleted but not watched — the client receivesnotification.channel_deletedinstead ofchannel.deleted, so the channel was previously not removed from the list.Also ports the expanded event-handling test suite added in the original PR.
Cherry-picked with manual conflict resolution in CHANGELOG and two refactored test bodies.
Screenshots / Videos
No UI changes.