-
Notifications
You must be signed in to change notification settings - Fork 320
Migrate the live location update request body to the generated UpdateLiveLocationRequest model #6636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gpunto
wants to merge
5
commits into
develop
Choose a base branch
from
migrate/live-location-request
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+149
−54
Open
Migrate the live location update request body to the generated UpdateLiveLocationRequest model #6636
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
59b4ab2
Migrate the live location update request body to the generated Update…
gpunto f1bcde8
Merge branch 'develop' into migrate/live-location-request
gpunto 00214bb
Note that the live location device id params are deprecated and inert
gpunto f654a90
Reference the removal ticket from the live location device id notes
gpunto 5d6bf31
Merge branch 'develop' into migrate/live-location-request
gpunto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 0 additions & 38 deletions
38
...in/java/io/getstream/chat/android/client/api2/model/requests/UpdateLiveLocationRequest.kt
This file was deleted.
Oops, something went wrong.
44 changes: 44 additions & 0 deletions
44
...lient/src/main/java/io/getstream/chat/android/network/models/UpdateLiveLocationRequest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * Copyright (c) 2014-2026 Stream.io Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Stream License; | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://github.com/GetStream/stream-chat-android/blob/main/LICENSE | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| @file:Suppress( | ||
| "ArrayInDataClass", | ||
| "EnumEntryName", | ||
| "RemoveRedundantQualifierName", | ||
| "UnusedImport", | ||
| ) | ||
|
|
||
| package io.getstream.chat.android.network.models | ||
|
|
||
| import com.squareup.moshi.Json | ||
|
|
||
| /** | ||
| * | ||
| */ | ||
| @com.squareup.moshi.JsonClass(generateAdapter = true) | ||
| internal data class UpdateLiveLocationRequest( | ||
| @Json(name = "message_id") | ||
| internal val messageId: String, | ||
|
|
||
| @Json(name = "end_at") | ||
| internal val endAt: java.util.Date? = null, | ||
|
|
||
| @Json(name = "latitude") | ||
| internal val latitude: Double? = null, | ||
|
|
||
| @Json(name = "longitude") | ||
| internal val longitude: Double? = null, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...est/java/io/getstream/chat/android/client/parser2/UpdateLiveLocationRequestAdapterTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Copyright (c) 2014-2026 Stream.io Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Stream License; | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://github.com/GetStream/stream-chat-android/blob/main/LICENSE | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.getstream.chat.android.client.parser2 | ||
|
|
||
| import io.getstream.chat.android.client.parser2.testdata.UpdateLiveLocationRequestTestData | ||
| import org.junit.jupiter.api.Assertions | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| internal class UpdateLiveLocationRequestAdapterTest { | ||
| private val parser = ParserFactory.createMoshiChatParser() | ||
|
|
||
| @Test | ||
| fun `Serialize UpdateLiveLocationRequest with new coordinates`() { | ||
| val json = parser.toJson(UpdateLiveLocationRequestTestData.coordinateUpdate) | ||
| Assertions.assertEquals(UpdateLiveLocationRequestTestData.coordinateUpdateJson, json) | ||
| } | ||
|
|
||
| @Test | ||
| fun `Serialize UpdateLiveLocationRequest that stops sharing`() { | ||
| val json = parser.toJson(UpdateLiveLocationRequestTestData.stopSharing) | ||
| Assertions.assertEquals(UpdateLiveLocationRequestTestData.stopSharingJson, json) | ||
| } | ||
| } |
54 changes: 54 additions & 0 deletions
54
...va/io/getstream/chat/android/client/parser2/testdata/UpdateLiveLocationRequestTestData.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* | ||
| * Copyright (c) 2014-2026 Stream.io Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Stream License; | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://github.com/GetStream/stream-chat-android/blob/main/LICENSE | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.getstream.chat.android.client.parser2.testdata | ||
|
|
||
| import io.getstream.chat.android.network.models.UpdateLiveLocationRequest | ||
| import org.intellij.lang.annotations.Language | ||
| import java.util.Date | ||
|
|
||
| internal object UpdateLiveLocationRequestTestData { | ||
|
|
||
| // Coordinates a 32-bit float cannot represent, so the test fails if they are ever narrowed. | ||
| private const val LATITUDE = 37.7749295 | ||
| private const val LONGITUDE = -122.4194155 | ||
|
|
||
| @Language("JSON") | ||
| val coordinateUpdateJson = | ||
| """{ | ||
| "message_id": "messageId", | ||
| "latitude": 37.7749295, | ||
| "longitude": -122.4194155 | ||
| }""".withoutWhitespace() | ||
|
|
||
| val coordinateUpdate = UpdateLiveLocationRequest( | ||
| messageId = "messageId", | ||
| latitude = LATITUDE, | ||
| longitude = LONGITUDE, | ||
| ) | ||
|
|
||
| @Language("JSON") | ||
| val stopSharingJson = | ||
| """{ | ||
| "message_id": "messageId", | ||
| "end_at": "2020-06-10T11:04:31.588Z" | ||
| }""".withoutWhitespace() | ||
|
|
||
| val stopSharing = UpdateLiveLocationRequest( | ||
| messageId = "messageId", | ||
| endAt = Date(1591787071588), | ||
| ) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.