Display voice recordings above other attachments in composer#6354
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
WalkthroughThe message composer attachment layout is reorganized to separate audio recordings from other attachments. Audio items now display at full width in a vertical column, while images, videos, and files are rendered in a horizontally scrolling row below, with each section managing its own spacing and dimensions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



Goal
Voice recording attachments in the message composer had a fixed 290dp width and were rendered inline in the horizontal attachment row, which could overflow the input field. This change separates voice recordings from other attachments so they span the full width of the composer.
Implementation
MessageComposerAttachments.kt: Split attachments viapartition { isAudioRecording() }. Audio recordings are rendered full-width above the horizontalLazyRowof other attachments (images, videos, files). Test tag moved to the outerColumn.MessageComposerAttachmentAudioRecordItem.kt: Changed from fixed.size(width = 290.dp, height = 72.dp)to.fillMaxWidth().height(72.dp)so it fills available width.UI Changes
vr-before.mp4
vr-after.mp4
Testing
Summary by CodeRabbit