fix: normalize H-polytope constraints in max_inscribed_ball#470
Open
Akash504-ai wants to merge 2 commits intoGeomScale:developfrom
Open
fix: normalize H-polytope constraints in max_inscribed_ball#470Akash504-ai wants to merge 2 commits intoGeomScale:developfrom
Akash504-ai wants to merge 2 commits intoGeomScale:developfrom
Conversation
Akash504-ai
force-pushed
the
fix-max-inscribed-ball-normalization
branch
2 times, most recently
from
f767fa3 to
19cd2f2
Compare
vissarion
reviewed
Mar 30, 2026
Member
vissarion
left a comment
vissarion
left a comment
There was a problem hiding this comment.
Thanks for this PR.
Could you please remove all changes unrelated to this fix, so the review and the commits are clean.
Also some tests seems to be broken in this branch (including test_max_ball_sparse).
Akash504-ai
force-pushed
the
fix-max-inscribed-ball-normalization
branch
from
19cd2f2 to
2236d6b
Compare
Contributor
Author
|
Thanks for the feedback! Actually the extra changes in the previous PR were due to formatting applied after implementing the fix that's why you are seeing many changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @vissarion,
I’ve opened a PR that normalizes the H-polytope constraints inside
max_inscribed_ball(), following the discussion in this issue.Due to memory limitations on my machine, I was not able to complete the full test build locally. It would be great if you could review the changes and confirm that the tests pass on your side.
Closes #366