Skip to content

feat(BrepTimeSeries): add time series import factory - #1339

Merged
BotellaA merged 2 commits into
nextfrom
feat/add_pvd_import
Oct 6, 2026
Merged

BotellaA merged 2 commits into
nextfrom
feat/add_pvd_import

Conversation

@BenPinet

@BenPinet BenPinet commented Oct 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@BenPinet
BenPinet requested a review from BotellaA October 6, 2026 12:25
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 1 concern(s)
  • bindings/python/src/model/representation/io/brep.cpp:34:10: warning: [misc-use-internal-linkage]

    function 'define_brep_io' can be made static or moved into an anonymous namespace to enforce internal linkage

       34 |     void define_brep_io( pybind11::module& module )
          |          ^
          |     static 

Have any feedback or feature suggestions? Share it here.

@BotellaA
BotellaA merged commit e05238e into next Oct 6, 2026
24 checks passed
@BotellaA
BotellaA deleted the feat/add_pvd_import branch October 6, 2026 13:51
@BotellaA

BotellaA commented Oct 6, 2026

Copy link
Copy Markdown
Member

🎉 This PR is included in version 18.4.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

BotellaA commented Oct 7, 2026

Copy link
Copy Markdown
Member

🎉 This PR is included in version 18.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants