feat(ModelBuilders): change parameters in model builder functions by BenPinet · Pull Request #1317 · Geode-solutions/OpenGeode

BenPinet · 2026-08-12T07:25:33Z

BREAKING CHANGE: take components instead of uuid in model builders such as set_surface_name

github-actions · 2026-08-12T07:45:19Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 517 concern(s)

bindings/python/src/model/mixin/builder/block_collections_builder.cpp:42:10: warning: [misc-use-internal-linkage]

function 'define_block_collections_builder' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   42 |     void define_block_collections_builder( pybind11::module& module )
      |          ^
      |     static 
```

bindings/python/src/model/mixin/builder/block_collections_builder.cpp:44:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   44 |         PYTHON_BLOCK_COLLECTIONS_BUILDER( 2 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/block_collections_builder.cpp:33:35: note: expanded from macro 'PYTHON_BLOCK_COLLECTIONS_BUILDER'
   33 |         "BlockCollectionsBuilder" + std::to_string( dimension ) + "D";         \
      |                                   ^

bindings/python/src/model/mixin/builder/block_collections_builder.cpp:45:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   45 |         PYTHON_BLOCK_COLLECTIONS_BUILDER( 3 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/block_collections_builder.cpp:33:35: note: expanded from macro 'PYTHON_BLOCK_COLLECTIONS_BUILDER'
   33 |         "BlockCollectionsBuilder" + std::to_string( dimension ) + "D";         \
      |                                   ^

bindings/python/src/model/mixin/builder/corner_collections_builder.cpp:42:10: warning: [misc-use-internal-linkage]

function 'define_corner_collections_builder' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   42 |     void define_corner_collections_builder( pybind11::module& module )
      |          ^
      |     static 
```

bindings/python/src/model/mixin/builder/corner_collections_builder.cpp:44:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   44 |         PYTHON_CORNER_COLLECTIONS_BUILDER( 2 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/corner_collections_builder.cpp:33:36: note: expanded from macro 'PYTHON_CORNER_COLLECTIONS_BUILDER'
   33 |         "CornerCollectionsBuilder" + std::to_string( dimension ) + "D";        \
      |                                    ^

bindings/python/src/model/mixin/builder/corner_collections_builder.cpp:45:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   45 |         PYTHON_CORNER_COLLECTIONS_BUILDER( 3 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/corner_collections_builder.cpp:33:36: note: expanded from macro 'PYTHON_CORNER_COLLECTIONS_BUILDER'
   33 |         "CornerCollectionsBuilder" + std::to_string( dimension ) + "D";        \
      |                                    ^

bindings/python/src/model/mixin/builder/corners_builder.cpp:45:10: warning: [misc-use-internal-linkage]

function 'define_corners_builder' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   45 |     void define_corners_builder( pybind11::module& module )
      |          ^
      |     static 
```

bindings/python/src/model/mixin/builder/corners_builder.cpp:47:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   47 |         PYTHON_CORNERS_BUILDER( 2 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/corners_builder.cpp:35:26: note: expanded from macro 'PYTHON_CORNERS_BUILDER'
   35 |         "CornersBuilder" + std::to_string( dimension ) + "D";                  \
      |                          ^

bindings/python/src/model/mixin/builder/corners_builder.cpp:48:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   48 |         PYTHON_CORNERS_BUILDER( 3 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/corners_builder.cpp:35:26: note: expanded from macro 'PYTHON_CORNERS_BUILDER'
   35 |         "CornersBuilder" + std::to_string( dimension ) + "D";                  \
      |                          ^

bindings/python/src/model/mixin/builder/line_collections_builder.cpp:41:10: warning: [misc-use-internal-linkage]

function 'define_line_collections_builder' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   41 |     void define_line_collections_builder( pybind11::module& module )
      |          ^
      |     static 
```

bindings/python/src/model/mixin/builder/line_collections_builder.cpp:43:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   43 |         PYTHON_LINE_COLLECTIONS_BUILDER( 2 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/line_collections_builder.cpp:33:34: note: expanded from macro 'PYTHON_LINE_COLLECTIONS_BUILDER'
   33 |         "LineCollectionsBuilder" + std::to_string( dimension ) + "D";          \
      |                                  ^

bindings/python/src/model/mixin/builder/line_collections_builder.cpp:44:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   44 |         PYTHON_LINE_COLLECTIONS_BUILDER( 3 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/line_collections_builder.cpp:33:34: note: expanded from macro 'PYTHON_LINE_COLLECTIONS_BUILDER'
   33 |         "LineCollectionsBuilder" + std::to_string( dimension ) + "D";          \
      |                                  ^

bindings/python/src/model/mixin/builder/lines_builder.cpp:44:10: warning: [misc-use-internal-linkage]

function 'define_lines_builder' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   44 |     void define_lines_builder( pybind11::module& module )
      |          ^
      |     static 
```

bindings/python/src/model/mixin/builder/lines_builder.cpp:46:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   46 |         PYTHON_LINES_BUILDER( 2 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/lines_builder.cpp:35:24: note: expanded from macro 'PYTHON_LINES_BUILDER'
   35 |         "LinesBuilder" + std::to_string( dimension ) + "D";                    \
      |                        ^

bindings/python/src/model/mixin/builder/lines_builder.cpp:47:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   47 |         PYTHON_LINES_BUILDER( 3 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/lines_builder.cpp:35:24: note: expanded from macro 'PYTHON_LINES_BUILDER'
   35 |         "LinesBuilder" + std::to_string( dimension ) + "D";                    \
      |                        ^

bindings/python/src/model/mixin/builder/model_boundaries_builder.cpp:41:10: warning: [misc-use-internal-linkage]

function 'define_model_boundaries_builder' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   41 |     void define_model_boundaries_builder( pybind11::module& module )
      |          ^
      |     static 
```

bindings/python/src/model/mixin/builder/model_boundaries_builder.cpp:43:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   43 |         PYTHON_MODEL_BOUNDARIES_BUILDER( 2 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/model_boundaries_builder.cpp:33:34: note: expanded from macro 'PYTHON_MODEL_BOUNDARIES_BUILDER'
   33 |         "ModelBoundariesBuilder" + std::to_string( dimension ) + "D";          \
      |                                  ^

bindings/python/src/model/mixin/builder/model_boundaries_builder.cpp:44:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   44 |         PYTHON_MODEL_BOUNDARIES_BUILDER( 3 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/model_boundaries_builder.cpp:33:34: note: expanded from macro 'PYTHON_MODEL_BOUNDARIES_BUILDER'
   33 |         "ModelBoundariesBuilder" + std::to_string( dimension ) + "D";          \
      |                                  ^

bindings/python/src/model/mixin/builder/surface_collections_builder.cpp:42:10: warning: [misc-use-internal-linkage]

function 'define_surface_collections_builder' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   42 |     void define_surface_collections_builder( pybind11::module& module )
      |          ^
      |     static 
```

bindings/python/src/model/mixin/builder/surface_collections_builder.cpp:44:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   44 |         PYTHON_SURFACE_COLLECTIONS_BUILDER( 2 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/surface_collections_builder.cpp:33:37: note: expanded from macro 'PYTHON_SURFACE_COLLECTIONS_BUILDER'
   33 |         "SurfaceCollectionsBuilder" + std::to_string( dimension ) + "D";       \
      |                                     ^

bindings/python/src/model/mixin/builder/surface_collections_builder.cpp:45:9: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   45 |         PYTHON_SURFACE_COLLECTIONS_BUILDER( 3 );
      |         ^
/__w/OpenGeode/OpenGeode/bindings/python/src/model/mixin/builder/surface_collections_builder.cpp:33:37: note: expanded from macro 'PYTHON_SURFACE_COLLECTIONS_BUILDER'
   33 |         "SurfaceCollectionsBuilder" + std::to_string( dimension ) + "D";       \
      |                                     ^

include/geode/model/helpers/internal/simplicial_model_creator.hpp:42:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   42 | namespace geode
      | ^~~~~~~~~~~~~~~
   43 | {
      | ~
   44 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal

include/geode/model/helpers/internal/simplicial_model_creator.hpp:150:17: warning: [bugprone-easily-swappable-parameters]

2 adjacent parameters of 'create_surfaces' of similar type ('absl::Span') are easily swapped by mistake

  150 |                 absl::Span< const uuid > corners,
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  151 |                 absl::Span< const uuid > lines,
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode/OpenGeode/include/geode/model/helpers/internal/simplicial_model_creator.hpp:150:42: note: the first parameter in the range is 'corners'
  150 |                 absl::Span< const uuid > corners,
      |                                          ^~~~~~~
/__w/OpenGeode/OpenGeode/include/geode/model/helpers/internal/simplicial_model_creator.hpp:151:42: note: the last parameter in the range is 'lines'
  151 |                 absl::Span< const uuid > lines,
      |                                          ^~~~~

include/geode/model/helpers/internal/simplicial_model_creator.hpp:174:28: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  174 |                 const auto id =
      |                            ^
```
include/geode/model/mixin/builder/blocks_builder.hpp:94:25: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   94 |             const uuid& id, std::unique_ptr< SolidMesh< dimension > > mesh );
      |                         ^
```
include/geode/model/mixin/builder/blocks_builder.hpp:97:25: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   97 |             const uuid& id );
      |                         ^
```
include/geode/model/mixin/builder/corners_builder.hpp:83:25: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   83 |             const uuid& id, std::unique_ptr< PointSet< dimension > > mesh );
      |                         ^
```
include/geode/model/mixin/builder/corners_builder.hpp:86:25: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   86 |             const uuid& id );
      |                         ^
```
include/geode/model/mixin/builder/lines_builder.hpp:79:25: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   79 |             const uuid& id, std::unique_ptr< EdgedCurve< dimension > > mesh );
      |                         ^
```
include/geode/model/mixin/builder/lines_builder.hpp:82:25: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   82 |             const uuid& id );
      |                         ^
```
include/geode/model/mixin/builder/model_boundaries_builder.hpp:47:47: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   47 |             const ModelBoundary< dimension >& id, std::string_view name );
      |                                               ^
```
include/geode/model/mixin/builder/model_boundaries_builder.hpp:50:47: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   50 |             const ModelBoundary< dimension >& id, bool active );
      |                                               ^
```
include/geode/model/mixin/builder/surfaces_builder.hpp:95:25: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   95 |             const uuid& id, std::unique_ptr< SurfaceMesh< dimension > > mesh );
      |                         ^
```
include/geode/model/mixin/builder/surfaces_builder.hpp:98:25: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   98 |             const uuid& id );
      |                         ^
```

include/geode/model/representation/builder/detail/copy.hpp:48:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   48 | namespace geode
      | ^~~~~~~~~~~~~~~
   49 | {
      | ~
   50 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail

include/geode/model/representation/builder/detail/copy.hpp:55:14: warning: [readability-function-cognitive-complexity]

function 'copy_corner_components' has cognitive complexity of 12 (threshold 10)

   55 |         void copy_corner_components( const ModelFrom& from,
      |              ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:60:13: note: +1, including nesting penalty of 0, nesting level increased to 1
   60 |             for( const auto& corner : from.corners() )
      |             ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:62:17: note: +2, including nesting penalty of 1, nesting level increased to 2
   62 |                 if( mapping.has_mapping_input( corner.id() ) )
      |                 ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:66:25: note: +3, including nesting penalty of 2, nesting level increased to 3
   66 |                         ? builder_to.add_corner( id, corner.mesh().impl_name() )
      |                         ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:69:17: note: +1, nesting level increased to 2
   69 |                 else
      |                 ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:73:29: note: +3, including nesting penalty of 2, nesting level increased to 3
   73 |                             ? builder_to.add_corner( corner.mesh().impl_name() )
      |                             ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:78:17: note: +2, including nesting penalty of 1, nesting level increased to 2
   78 |                 if( const auto name = corner.name() )
      |                 ^

include/geode/model/representation/builder/detail/copy.hpp:64:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
   64 |                     const auto& id = mapping.in2out( corner.id() );
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:71:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
   71 |                     const auto& id =
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:77:29: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
   77 |                 const auto& id = mapping.in2out( corner.id() );
      |                             ^
```

include/geode/model/representation/builder/detail/copy.hpp:89:14: warning: [readability-function-cognitive-complexity]

function 'copy_line_components' has cognitive complexity of 12 (threshold 10)

   89 |         void copy_line_components( const ModelFrom& from,
      |              ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:94:13: note: +1, including nesting penalty of 0, nesting level increased to 1
   94 |             for( const auto& line : from.lines() )
      |             ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:96:17: note: +2, including nesting penalty of 1, nesting level increased to 2
   96 |                 if( mapping.has_mapping_input( line.id() ) )
      |                 ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:100:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  100 |                         ? builder_to.add_line( id, line.mesh().impl_name() )
      |                         ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:103:17: note: +1, nesting level increased to 2
  103 |                 else
      |                 ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:107:29: note: +3, including nesting penalty of 2, nesting level increased to 3
  107 |                             ? builder_to.add_line( line.mesh().impl_name() )
      |                             ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:112:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  112 |                 if( const auto name = line.name() )
      |                 ^

include/geode/model/representation/builder/detail/copy.hpp:98:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
   98 |                     const auto& id = mapping.in2out( line.id() );
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:105:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  105 |                     const auto& id =
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:111:29: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  111 |                 const auto& id = mapping.in2out( line.id() );
      |                             ^
```

include/geode/model/representation/builder/detail/copy.hpp:123:14: warning: [readability-function-cognitive-complexity]

function 'copy_surface_components' has cognitive complexity of 12 (threshold 10)

  123 |         void copy_surface_components( const ModelFrom& from,
      |              ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:128:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  128 |             for( const auto& surface : from.surfaces() )
      |             ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:130:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  130 |                 if( mapping.has_mapping_input( surface.id() ) )
      |                 ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:134:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  134 |                         ? builder_to.add_surface(
      |                         ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:138:17: note: +1, nesting level increased to 2
  138 |                 else
      |                 ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:141:42: note: +3, including nesting penalty of 2, nesting level increased to 3
  141 |                                          ? builder_to.add_surface(
      |                                          ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:147:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  147 |                 if( const auto name = surface.name() )
      |                 ^

include/geode/model/representation/builder/detail/copy.hpp:132:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  132 |                     const auto& id = mapping.in2out( surface.id() );
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:140:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  140 |                     const auto& id = ModelFrom::dim == ModelTo::dim
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:146:29: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  146 |                 const auto& id = mapping.in2out( surface.id() );
      |                             ^
```

include/geode/model/representation/builder/detail/copy.hpp:158:14: warning: [readability-function-cognitive-complexity]

function 'copy_block_components' has cognitive complexity of 12 (threshold 10)

  158 |         void copy_block_components( const ModelFrom& from,
      |              ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:163:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  163 |             for( const auto& block : from.blocks() )
      |             ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:165:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  165 |                 if( mapping.has_mapping_input( block.id() ) )
      |                 ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:169:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  169 |                         ? builder_to.add_block( id, block.mesh().impl_name() )
      |                         ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:172:17: note: +1, nesting level increased to 2
  172 |                 else
      |                 ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:176:29: note: +3, including nesting penalty of 2, nesting level increased to 3
  176 |                             ? builder_to.add_block( block.mesh().impl_name() )
      |                             ^
/__w/OpenGeode/OpenGeode/include/geode/model/representation/builder/detail/copy.hpp:181:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  181 |                 if( const auto name = block.name() )
      |                 ^

include/geode/model/representation/builder/detail/copy.hpp:167:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  167 |                     const auto& id = mapping.in2out( block.id() );
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:174:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  174 |                     const auto& id =
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:180:29: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  180 |                 const auto& id = mapping.in2out( block.id() );
      |                             ^
```
include/geode/model/representation/builder/detail/copy.hpp:201:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  201 |                     const auto& id = mapping.in2out( model_boundary.id() );
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:206:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  206 |                     const auto& id = builder_to.add_model_boundary();
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:209:29: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  209 |                 const auto& id = mapping.in2out( model_boundary.id() );
      |                             ^
```
include/geode/model/representation/builder/detail/copy.hpp:230:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  230 |                     const auto& id = mapping.in2out( corner_collection.id() );
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:235:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  235 |                     const auto& id = builder_to.add_corner_collection();
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:238:29: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  238 |                 const auto& id = mapping.in2out( corner_collection.id() );
      |                             ^
```
include/geode/model/representation/builder/detail/copy.hpp:260:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  260 |                     const auto& id = mapping.in2out( line_collection.id() );
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:265:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  265 |                     const auto& id = builder_to.add_line_collection();
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:268:29: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  268 |                 const auto& id = mapping.in2out( line_collection.id() );
      |                             ^
```
include/geode/model/representation/builder/detail/copy.hpp:290:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  290 |                     const auto& id = mapping.in2out( surface_collection.id() );
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:295:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  295 |                     const auto& id = builder_to.add_surface_collection();
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:298:29: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  298 |                 const auto& id = mapping.in2out( surface_collection.id() );
      |                             ^
```
include/geode/model/representation/builder/detail/copy.hpp:320:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  320 |                     const auto& id = mapping.in2out( block_collection.id() );
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:325:33: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  325 |                     const auto& id = builder_to.add_block_collection();
      |                                 ^
```
include/geode/model/representation/builder/detail/copy.hpp:328:29: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  328 |                 const auto& id = mapping.in2out( block_collection.id() );
      |                             ^
```
include/geode/model/representation/builder/detail/copy.hpp:342:35: warning: [cppcoreguidelines-missing-std-forward]

forwarding reference parameter 'range' is never forwarded inside the function body
```
  342 |             clone_meshes( Range&& range, index_t nb_components )
      |                                   ^
```
include/geode/model/representation/builder/detail/copy.hpp:432:29: warning: [readability-identifier-length]

parameter name 'v' is too short, expected at least 3 characters
```
  432 |                     index_t v ) {
      |                             ^
```

include/geode/model/representation/core/detail/transfer_metadata.hpp:46:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   46 | namespace geode
      | ^~~~~~~~~~~~~~~
   47 | {
      | ~
   48 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail

src/geode/model/helpers/convert_brep_section.cpp:55:24: warning: [readability-identifier-length]

parameter name 'to' is too short, expected at least 3 characters
```
   55 |         const ModelTo& to,
      |                        ^
```
src/geode/model/helpers/convert_brep_section.cpp:84:9: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
   84 |         SectionExtruder( const geode::Section& section )
      |         ^
      |         explicit 
```
src/geode/model/helpers/convert_brep_section.cpp:202:32: warning: [performance-unnecessary-copy-initialization]

the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference
```
  202 |                 if( const auto name = model_boundary.name() )
      |                                ^
      |                               &
```

src/geode/model/helpers/convert_brep_section.cpp:245:17: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'pointids'

  245 |                 std::array< geode::index_t, 4 > pointids;
      |                 ^                                       
      |                                                         {}

src/geode/model/helpers/convert_brep_section.cpp:347:17: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'pointids'

  347 |                 std::array< geode::index_t, 6 > pointids;
      |                 ^                                       
      |                                                         {}

src/geode/model/helpers/convert_brep_section.cpp:347:45: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
  347 |                 std::array< geode::index_t, 6 > pointids;
      |                                             ^
```
src/geode/model/helpers/convert_brep_section.cpp:348:33: warning: [readability-identifier-length]

variable name 'p0' is too short, expected at least 3 characters
```
  348 |                 for( const auto p0 : geode::LRange{ 3 } )
      |                                 ^
```
src/geode/model/helpers/convert_model_meshes.cpp:98:26: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
   98 |                 surface, std::move( tri_surface ).value() );
      |                          ^
```

src/geode/model/helpers/convert_model_meshes.cpp:161:47: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value

  161 |             builder.update_block_mesh( block, std::move( tet_solid ).value() );
      |                                               ^

src/geode/model/helpers/convert_model_meshes.cpp:172:24: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
  172 |                 block, std::move( hybrid_solid ).value() );
      |                        ^
```
src/geode/model/helpers/convert_model_meshes.cpp:196:10: warning: [misc-use-internal-linkage]

function 'convert_surface_meshes_into_triangulated_surfaces' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  196 |     void convert_surface_meshes_into_triangulated_surfaces( BRep& brep )
      |          ^
      |     static 
```

src/geode/model/helpers/create_coordinate_system.cpp:84:10: warning: [readability-function-size]

function 'create_generic_model_coordinate_system' exceeds recommended size/complexity thresholds

   84 |     void create_generic_model_coordinate_system( const Model& model,
      |          ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/create_coordinate_system.cpp:84:10: note: 5 parameters (threshold 4)

src/geode/model/helpers/create_coordinate_system.cpp:116:10: warning: [readability-function-size]

function 'create_brep_coordinate_system' exceeds recommended size/complexity thresholds

  116 |     void create_brep_coordinate_system( const BRep& model,
      |          ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/create_coordinate_system.cpp:116:10: note: 5 parameters (threshold 4)

src/geode/model/helpers/create_coordinate_system.cpp:133:10: warning: [readability-function-size]

function 'create_section_coordinate_system' exceeds recommended size/complexity thresholds

  133 |     void create_section_coordinate_system( const Section& model,
      |          ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/create_coordinate_system.cpp:133:10: note: 5 parameters (threshold 4)

src/geode/model/helpers/detail/build_model_boundaries.cpp:75:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   75 | namespace geode
      | ^~~~~~~~~~~~~~~
   76 | {
      | ~
   77 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail

src/geode/model/helpers/detail/solid_mesh_validity_fix.cpp:39:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   39 | namespace geode
      | ^~~~~~~~~~~~~~~
   40 | {
      | ~
   41 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail

src/geode/model/helpers/detail/split_along_block_mesh_borders.cpp:44:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   44 | namespace geode
      | ^~~~~~~~~~~~~~~
   45 | {
      | ~
   46 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail

src/geode/model/helpers/detail/split_along_block_mesh_borders.cpp:176:13: warning: [modernize-use-nodiscard]

function 'mesh_border_facets' should be marked [[nodiscard]]
```
  176 |             std::vector< PolyhedronFacet > mesh_border_facets(
      |             ^
      |             [[nodiscard]] 
```

src/geode/model/helpers/detail/split_along_block_mesh_borders.cpp:176:44: warning: [readability-function-cognitive-complexity]

function 'mesh_border_facets' has cognitive complexity of 16 (threshold 10)

  176 |             std::vector< PolyhedronFacet > mesh_border_facets(
      |                                            ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_block_mesh_borders.cpp:181:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  181 |                 for( const auto& surface : model_.internal_surfaces( block ) )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_block_mesh_borders.cpp:184:21: note: +2, including nesting penalty of 1, nesting level increased to 2
  184 |                     for( const auto p : Range{ mesh.nb_polygons() } )
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_block_mesh_borders.cpp:186:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  186 |                         for( auto& facet :
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_block_mesh_borders.cpp:190:29: note: +4, including nesting penalty of 3, nesting level increased to 4
  190 |                             if( !block_mesh.is_polyhedron_facet_on_border(
      |                             ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_block_mesh_borders.cpp:198:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  198 |                 for( const auto polyhedron_id :
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_block_mesh_borders.cpp:201:21: note: +2, including nesting penalty of 1, nesting level increased to 2
  201 |                     for( const auto facet_id :
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_block_mesh_borders.cpp:206:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  206 |                         if( block_mesh.is_polyhedron_facet_on_border( facet ) )
      |                         ^

src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:48:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   48 | namespace geode
      | ^~~~~~~~~~~~~~~
   49 | {
      | ~
   50 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail

src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:64:17: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
   64 |                 SurfaceInfo( index_t nb_vertices )
      |                 ^
      |                 explicit 
```
src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:73:13: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
   73 |             Impl( Model& model )
      |             ^
      |             explicit 
```
src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:208:13: warning: [modernize-use-nodiscard]

function 'compute_surface_info' should be marked [[nodiscard]]
```
  208 |             SurfaceInfo compute_surface_info(
      |             ^
      |             [[nodiscard]] 
```

src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:239:18: warning: [readability-function-cognitive-complexity]

function 'remove_adjacencies_along_internal_lines' has cognitive complexity of 14 (threshold 10)

  239 |             void remove_adjacencies_along_internal_lines(
      |                  ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:244:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  244 |                 for( const auto& line : model_.internal_lines( surface ) )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:247:21: note: +2, including nesting penalty of 1, nesting level increased to 2
  247 |                     for( const auto edge_id : Range{ mesh.nb_edges() } )
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:253:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  253 |                         if( it == surface_edges.end() )
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:257:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  257 |                         for( auto& edge : it->second )
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:260:29: note: +4, including nesting penalty of 3, nesting level increased to 4
  260 |                             if( const auto adj_edge =
      |                             ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:269:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  269 |                 for( const auto& edge : edges )
      |                 ^

src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:252:36: warning: [readability-identifier-length]

variable name 'it' is too short, expected at least 3 characters
```
  252 |                         const auto it = surface_edges.find( surface.id() );
      |                                    ^
```

src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:275:24: warning: [readability-function-size]

function 'process_component' exceeds recommended size/complexity thresholds

  275 |             CMVmapping process_component( const Surface< dimension >& surface,
      |                        ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:275:24: note: 6 parameters (threshold 4)

src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:279:17: warning: [bugprone-easily-swappable-parameters]

2 adjacent parameters of 'process_component' of similar type ('const PolygonsAroundVertex &') are easily swapped by mistake

  279 |                 const PolygonsAroundVertex& total_polygons,
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  280 |                 const PolygonsAroundVertex& polygon_vertices )
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:279:45: note: the first parameter in the range is 'total_polygons'
  279 |                 const PolygonsAroundVertex& total_polygons,
      |                                             ^~~~~~~~~~~~~~
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/detail/split_along_surface_mesh_borders.cpp:280:45: note: the last parameter in the range is 'polygon_vertices'
  280 |                 const PolygonsAroundVertex& polygon_vertices )
      |                                             ^~~~~~~~~~~~~~~~

src/geode/model/helpers/detail/surface_mesh_validity_fix.cpp:42:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   42 | namespace geode
      | ^~~~~~~~~~~~~~~
   43 | {
      | ~
   44 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail

src/geode/model/helpers/simplicial_brep_creator.cpp:45:25: warning: [cppcoreguidelines-avoid-magic-numbers]

8 is a magic number; consider replacing it with a named constant
```
   45 |         points.reserve( 8 );
      |                         ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:66:29: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   66 |             { 3 }, { 4 }, { 5 }, { 6 }, { 7 } };
      |                             ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:66:36: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   66 |             { 3 }, { 4 }, { 5 }, { 6 }, { 7 } };
      |                                    ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:66:43: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   66 |             { 3 }, { 4 }, { 5 }, { 6 }, { 7 } };
      |                                           ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:76:20: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   76 |             { { 4, 5 } },
      |                    ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:77:17: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   77 |             { { 5, 6 } },
      |                 ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:77:20: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   77 |             { { 5, 6 } },
      |                    ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:78:17: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   78 |             { { 6, 7 } },
      |                 ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:78:20: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   78 |             { { 6, 7 } },
      |                    ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:79:17: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   79 |             { { 7, 4 } },
      |                 ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:81:20: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   81 |             { { 1, 5 } },
      |                    ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:82:20: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   82 |             { { 2, 6 } },
      |                    ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:83:20: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   83 |             { { 3, 7 } },
      |                    ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:91:20: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   91 |             { { 4, 5, 6, 7 }, { 0, 1, 2, 0, 2, 3 }, { 4, 5, 6, 7 }, {}, {} },
      |                    ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:91:23: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   91 |             { { 4, 5, 6, 7 }, { 0, 1, 2, 0, 2, 3 }, { 4, 5, 6, 7 }, {}, {} },
      |                       ^
```
src/geode/model/helpers/simplicial_brep_creator.cpp:91:26: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   91 |             { { 4, 5, 6, 7 }, { 0, 1, 2, 0, 2, 3 }, { 4, 5, 6, 7 }, {}, {} },
      |                          ^
```

src/geode/model/helpers/simplicial_brep_creator.cpp:91:58: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant

   91 |             { { 4, 5, 6, 7 }, { 0, 1, 2, 0, 2, 3 }, { 4, 5, 6, 7 }, {}, {} },
      |                                                          ^

src/geode/model/helpers/simplicial_brep_creator.cpp:91:61: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant

   91 |             { { 4, 5, 6, 7 }, { 0, 1, 2, 0, 2, 3 }, { 4, 5, 6, 7 }, {}, {} },
      |                                                             ^

src/geode/model/helpers/simplicial_brep_creator.cpp:91:64: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant

   91 |             { { 4, 5, 6, 7 }, { 0, 1, 2, 0, 2, 3 }, { 4, 5, 6, 7 }, {}, {} },
      |                                                                ^

src/geode/model/helpers/simplicial_brep_creator.cpp:92:23: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   92 |             { { 0, 1, 5, 4 }, { 0, 1, 2, 0, 2, 3 }, { 0, 9, 4, 8 }, {}, {} },
      |                       ^
```

src/geode/model/helpers/simplicial_brep_creator.cpp:92:58: warning: [cppcoreguidelines-avoid-magic-numbers]

9 is a magic number; consider replacing it with a named constant

   92 |             { { 0, 1, 5, 4 }, { 0, 1, 2, 0, 2, 3 }, { 0, 9, 4, 8 }, {}, {} },
      |                                                          ^

src/geode/model/helpers/simplicial_brep_creator.cpp:92:64: warning: [cppcoreguidelines-avoid-magic-numbers]

8 is a magic number; consider replacing it with a named constant

   92 |             { { 0, 1, 5, 4 }, { 0, 1, 2, 0, 2, 3 }, { 0, 9, 4, 8 }, {}, {} },
      |                                                                ^

Have any feedback or feature suggestions? Share it here.

feat(ModelBuilders): change parameters in model builder functions

50f874a

BREAKING CHANGE: take components instead of uuid in model builders such as set_surface_name

BenPinet requested a review from panquez August 12, 2026 07:25

panquez approved these changes Aug 12, 2026

View reviewed changes

Comment thread include/geode/model/mixin/builder/surfaces_builder.hpp Outdated

Comment thread include/geode/model/representation/builder/detail/copy.hpp Outdated

pierre's comments

5e89a6c

BotellaA merged commit f34b8bb into v18 Aug 12, 2026
19 checks passed

BotellaA deleted the feat/change_input_parameters_of_functions_in_model_builders branch August 12, 2026 14:17

Navigation Menu

Uh oh!

Uh oh!

feat(ModelBuilders): change parameters in model builder functions - #1317

feat(ModelBuilders): change parameters in model builder functions#1317
BotellaA merged 2 commits into
v18from
feat/change_input_parameters_of_functions_in_model_builders

BenPinet commented Aug 12, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

BenPinet commented Aug 12, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Aug 12, 2026 •

edited

Loading