V18 by BenPinet · Pull Request #5 · Geode-solutions/OpenGeode-Inspector_Geosciences

BenPinet · 2026-08-04T09:40:47Z

No description provided.

…with_warning fix(ABI): abi fix

github-actions · 2026-08-04T13:54:56Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 19 concern(s)

src/geode/inspector_geosciences/inspection/geology/cross_section_geology.cpp:60:9: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
   60 |         Impl( const CrossSection& model ) : model_( model ) {}
      |         ^
      |         explicit 
```
src/geode/inspector_geosciences/inspection/geology/cross_section_geology.cpp:132:9: warning: [modernize-use-nodiscard]

function 'horizon_invalidity' should be marked [[nodiscard]]
```
  132 |         std::optional< std::string > horizon_invalidity(
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector_geosciences/inspection/geology/cross_section_geology.cpp:165:9: warning: [modernize-use-nodiscard]

function 'surface_is_in_a_fault_block' should be marked [[nodiscard]]
```
  165 |         bool surface_is_in_a_fault_block( const Surface2D& surface ) const
      |         ^
      |         [[nodiscard]] 
```

src/geode/inspector_geosciences/inspection/geology/cross_section_geology.cpp:169:32: error: [clang-diagnostic-error]

reference to non-static member function must be called; did you mean to call it with no arguments?

  169 |                 if( collection.type == FaultBlock2D::component_type_static() )
      |                     ~~~~~~~~~~~^~~~
      |                                    ()
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:67:44: note: possible target for call
   67 |         [[nodiscard]] const ComponentType& type() const&
      |                                            ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:72:39: note: possible target for call
   72 |         [[nodiscard]] ComponentType&& type() &&
      |                                       ^

src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:48:32: error: [clang-diagnostic-error]

reference to non-static member function must be called; did you mean to call it with no arguments?

   48 |                     collection.type )
      |                     ~~~~~~~~~~~^~~~
      |                                    ()
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:65:18: note: in instantiation of function template specialization '(anonymous namespace)::component_is_linked_to_geology<geode::CrossSection>' requested here
   65 |             if( !component_is_linked_to_geology( model, component.id() ) )
      |                  ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:77:16: note: in instantiation of function template specialization '(anonymous namespace)::components_are_linked_to_geology<geode::CrossSection, geode::Corners<2>::CornerRange>' requested here
   77 |         return components_are_linked_to_geology( model, model.corners() )
      |                ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:110:22: note: in instantiation of function template specialization '(anonymous namespace)::components_are_linked_to_geology_base<geode::CrossSection>' requested here
  110 |             return ::components_are_linked_to_geology_base( model );
      |                      ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:67:44: note: possible target for call
   67 |         [[nodiscard]] const ComponentType& type() const&
      |                                            ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:72:39: note: possible target for call
   72 |         [[nodiscard]] ComponentType&& type() &&
      |                                       ^

src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:49:31: error: [clang-diagnostic-error]

reference to non-static member function must be called; did you mean to call it with no arguments?

   49 |                 || collection.type
      |                    ~~~~~~~~~~~^~~~
      |                                   ()
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:67:44: note: possible target for call
   67 |         [[nodiscard]] const ComponentType& type() const&
      |                                            ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:72:39: note: possible target for call
   72 |         [[nodiscard]] ComponentType&& type() &&
      |                                       ^

src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:61:44: warning: [performance-unnecessary-value-param]

the parameter 'component_range' is copied for each invocation but only used as a const reference; consider making it a const reference
```
   61 |         const Model& model, ComponentRange component_range )
      |                                            ^
      |                             const         &
```
src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:85:24: warning: [performance-unnecessary-value-param]

the parameter 'component_range' is copied for each invocation but only used as a const reference; consider making it a const reference
```
   85 |         ComponentRange component_range )
      |                        ^
      |         const         &
```

src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:101:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

  101 | namespace geode
      | ^~~~~~~~~~~~~~~
  102 | {
      | ~
  103 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal

src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:148:14: warning: [readability-function-cognitive-complexity]

function 'model_geological_components_are_linked_to_geometry' has cognitive complexity of 12 (threshold 10)

  148 |         bool model_geological_components_are_linked_to_geometry(
      |              ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:151:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  151 |             for( const auto& fault_block : model.fault_blocks() )
      |             ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:153:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  153 |                 if( model.nb_items( fault_block.id() ) == 0 )
      |                 ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:158:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  158 |             for( const auto& fault : model.faults() )
      |             ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:160:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  160 |                 if( model.nb_items( fault.id() ) == 0 )
      |                 ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:165:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  165 |             for( const auto& horizon : model.horizons() )
      |             ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:167:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  167 |                 if( model.nb_items( horizon.id() ) == 0 )
      |                 ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:172:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  172 |             for( const auto& stratigraphic_unit : model.stratigraphic_units() )
      |             ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:174:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  174 |                 if( model.nb_items( stratigraphic_unit.id() ) == 0 )
      |                 ^

src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:183:14: warning: [readability-function-cognitive-complexity]

function 'add_model_geological_components_not_linked_to_geometry' has cognitive complexity of 12 (threshold 10)

  183 |         void add_model_geological_components_not_linked_to_geometry(
      |              ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:186:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  186 |             for( const auto& fault_block : model.fault_blocks() )
      |             ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:188:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  188 |                 if( model.nb_items( fault_block.id() ) == 0 )
      |                 ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:196:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  196 |             for( const auto& fault : model.faults() )
      |             ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:198:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  198 |                 if( model.nb_items( fault.id() ) == 0 )
      |                 ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:206:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  206 |             for( const auto& horizon : model.horizons() )
      |             ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:208:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  208 |                 if( model.nb_items( horizon.id() ) == 0 )
      |                 ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:216:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  216 |             for( const auto& stratigraphic_unit : model.stratigraphic_units() )
      |             ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/src/geode/inspector_geosciences/inspection/geology/geology_helpers.cpp:218:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  218 |                 if( model.nb_items( stratigraphic_unit.id() ) == 0 )
      |                 ^

src/geode/inspector_geosciences/inspection/geology/structural_model_geology.cpp:61:9: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
   61 |         Impl( const StructuralModel& model ) : model_( model ) {}
      |         ^
      |         explicit 
```
src/geode/inspector_geosciences/inspection/geology/structural_model_geology.cpp:133:9: warning: [modernize-use-nodiscard]

function 'horizon_invalidity' should be marked [[nodiscard]]
```
  133 |         std::optional< std::string > horizon_invalidity(
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector_geosciences/inspection/geology/structural_model_geology.cpp:166:9: warning: [modernize-use-nodiscard]

function 'block_is_in_a_fault_block' should be marked [[nodiscard]]
```
  166 |         bool block_is_in_a_fault_block( const Block3D& block ) const
      |         ^
      |         [[nodiscard]] 
```

src/geode/inspector_geosciences/inspection/geology/structural_model_geology.cpp:170:32: error: [clang-diagnostic-error]

reference to non-static member function must be called; did you mean to call it with no arguments?

  170 |                 if( collection.type == FaultBlock3D::component_type_static() )
      |                     ~~~~~~~~~~~^~~~
      |                                    ()
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:67:44: note: possible target for call
   67 |         [[nodiscard]] const ComponentType& type() const&
      |                                            ^
/__w/OpenGeode-Inspector_Geosciences/OpenGeode-Inspector_Geosciences/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/component_type.hpp:72:39: note: possible target for call
   72 |         [[nodiscard]] ComponentType&& type() &&
      |                                       ^

tests/inspection/test-structural-model-inspection.cpp:40:6: warning: [misc-use-internal-linkage]

function 'check_model_A2' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   40 | void check_model_A2()
      |      ^
      | static 
```
tests/inspection/test-structural-model-inspection.cpp:40:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_model_A2'
```
   40 | void check_model_A2()
      |      ^~~~~~~~~~~~~~
      |      check_model_a2
```

tests/inspection/test-structural-model-inspection.cpp:51:54: warning: [readability-math-missing-parentheses]

'*' has higher precedence than '+'; add parentheses to explicitly specify the order of operations

   51 |     const geode::index_t expected_nb_geology_issues{ model.nb_blocks() * 2
      |                                                      ^~~~~~~~~~~~~~~~~~~~~
      |                                                      (                    )

tests/inspection/test-structural-model-inspection.cpp:64:6: warning: [misc-use-internal-linkage]

function 'check_implicit_model' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   64 | void check_implicit_model()
      |      ^
      | static 
```

Have any feedback or feature suggestions? Share it here.

fix(abi): abi fix

…uple fix(MakeTuple): test

…rs_of_functions_in_model_builders feat(ModelBuilders): model builder changes

…struct fix(ComponentID): change componentid class to struct

BenPinet and others added 3 commits August 3, 2026 16:03

fix(ABI): abi fix

ff03061

Apply prepare changes

f6df192

Merge pull request #4 from Geode-solutions/feat/replace_replace_warn_…

ac39d44

…with_warning fix(ABI): abi fix

BenPinet requested a review from BotellaA August 4, 2026 09:40

BenPinet and others added 2 commits August 4, 2026 15:52

Merge branch 'next' into v18

6e60094

Apply prepare changes

7a77202

BenPinet and others added 10 commits August 4, 2026 17:26

fix(abi): abi fix

701ef5a

Merge pull request #6 from Geode-solutions/feat/put_sign_struct_in_caps

30afa75

fix(abi): abi fix

fix(MakeTuple): test

4b2d3d3

Merge pull request #7 from Geode-solutions/fix/remove_make_pair_and_t…

81971f5

…uple fix(MakeTuple): test

feat(ModelBuilders): model builder changes

0c453ad

Apply prepare changes

2e5949b

Merge pull request #8 from Geode-solutions/feat/change_input_paramete…

1244b35

…rs_of_functions_in_model_builders feat(ModelBuilders): model builder changes

fix(ComponentID): change componentid class to struct

bdc14dd

Apply prepare changes

0b0d543

Merge pull request #9 from Geode-solutions/fix/change_ComponentID_to_…

1f283cd

…struct fix(ComponentID): change componentid class to struct

Navigation Menu

Uh oh!

V18 - #5

V18#5
BenPinet wants to merge 15 commits into
nextfrom
v18

BenPinet commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

BenPinet commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Aug 4, 2026 •

edited

Loading