Repository navigation
Use GenomicsDB/TileDB as the TileDB submodule, at its latest main - #359
Conversation
…is was a warning, now it is an error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #359 +/- ##
===========================================
+ Coverage 75.99% 77.32% +1.32%
===========================================
Files 146 144 -2
Lines 24184 23061 -1123
Branches 3016 3018 +2
===========================================
- Hits 18379 17832 -547
+ Misses 5591 5015 -576
Partials 214 214 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…l to Node 24 actions
| env: | ||
| # CMake 4 rejects cmake_minimum_required < 3.5, which old bundled dependencies | ||
| # such as aws-c-common from TileDB still declare. | ||
| CMAKE_POLICY_VERSION_MINIMUM: 3.5 |
There was a problem hiding this comment.
This can be removed when we accept all the TileDB changes
tfenne
left a comment
There was a problem hiding this comment.
Thanks, this is great to see: CI green on current runners, and the Hadoop/Spark cache fix and download timeouts will save a lot of waiting (we hit the slow archive.apache.org downloads on the TileDB side too).
One thing I think needs fixing before merge: release_test.yml now checks out GenomicsDB/TestGenomicsDBJar at main, but that repository still only has master, so the release test would fail at checkout. Could be fixed either here or renaming master in the other repo.
The rest are notes rather than requests, and I'm happy to pick any of them up in follow-up PRs:
- The TileDB submodule is at 0d3095a; TileDB main has since picked up GenomicsDB/TileDB#8, GenomicsDB/TileDB#13, GenomicsDB/TileDB#14 and GenomicsDB/TileDB#16 (the error-message buffer overflow and the two aarch64 char fixes); we can also bump the pin once we stop merging things into TileDB in a few days.
- Once TileDB GenomicsDB/TileDB#12 is in, TileDB's SDK builds handle CMake 4 themselves and the CMAKE_POLICY_VERSION_MINIMUM workaround can go.
- release.yml and release_test.yml still run on macos-13, which has been retired, so the next release tag would fail on its macOS jobs. I have a macOS release job working in our fork that I can bring across.
- Hadoop 3.3.5 and Spark 3.4.0 aren't on dlcdn.apache.org any more, so uncached downloads still come from the archive; bumping them, as you note for Spark, will let the dlcdn path pay off.
- The README table header still says "Master".
Done!!
Yes, we can bump up the TileDB pin once we merge the remaining TileDB PRs.
Yes, I placed a comment for that.
I did not change anything there, so feel free to PR your changes. Thanks.
We need to bump these, but left it for later.
Done!! |
|



This is the initial set of changes to use GenomicsDB/TileDB as the TileDB submodule, and to get GenomicsDB building again on the current GitHub runners.
TileDB submodule
dependencies/TileDBnow points athttps://github.com/GenomicsDB/TileDB.git, at its latestmain(0d3095a, up from8f497fc).Build fixes
CMakeLists.txtpasses-Dgenomicsdb.versiontomvn versions:settoo. Maven 3.9.10 and later reject the unresolved${genomicsdb.version}inpom.xml's<version>; older Maven only warned.cmake_minimum_requiredolder than 3.5. Old dependencies that TileDB builds, starting withaws-c-common, still declare one, so the workflow setsCMAKE_POLICY_VERSION_MINIMUM: 3.5. CMake 3.x on the Ubuntu runners ignores it. The proper fix belongs in TileDB's dependency builds.install_macos_prereqs.shinstalls the pinned lcov 1.16 formula through a local tap.CI (
basic.ymland friends)ubuntu-22.04andmacos-15-intel, and CodeQL runs onubuntu-latest.dlcdn.apache.orgfirst, falling back toarchive.apache.org, with retries andwget --timeout=60so a stalled download fails instead of hanging.manual_trigger) until a newnotify-codecovjob runs after all the build jobs have uploaded, so they no longer report on partial coverage.checkout@v7,setup-python@v7,setup-java@v6,cache@v6,codecov-action@v7).master→mainThe default branch has been renamed, so references to it now say
main: workflow branch checks and triggers (basic.yml,codeql.yml), therelease_test.ymlcheckout,tag_for_docker_release.sh, the README badges, thedocs/apis.rstsource link and the license URL inpom.xml.Follow-ups
CMAKE_POLICY_VERSION_MINIMUMcan be dropped.