-
Notifications
You must be signed in to change notification settings - Fork 243
Figure.pygmtlogo: Improved positioning of horizontal wordmark for circular PyGMT logo #4627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seisman
wants to merge
20
commits into
pygmtlogo
Choose a base branch
from
pygmtlogo-font
base: pygmtlogo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−6
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
88f381a
Allow adjust font
seisman 6abbcfd
Merge branch 'pygmtlogo' into pygmtlogo-font
seisman 5693140
Merge branch 'pygmtlogo' into pygmtlogo-font
seisman 7b9f053
Revert "Allow adjust font"
seisman 6cdbc34
Figure.pygmtlogo: Accurate positioning of the horizontal wordmark
seisman a8330fd
Add debugging lines for horizontal wordmark
seisman f03bd50
Smaller region for horizontal wordmark
seisman 479cb58
Update the baseline image for horizontal wordmark design
seisman 3f9affe
Reorder variables
seisman be6c052
Add a test and baseline image for circular logo with horizontal wordmark
seisman 0bad58f
Merge branch 'pygmtlogo' into pygmtlogo-font
seisman 6988c0f
Update baseline images
seisman f6d08a0
Simplify the test script
seisman 3fdfb56
Figure.pygmtlogo: Parameterize existing tests
seisman b29bdc9
Remove two dvc files
seisman b4e1e38
Rename test_pygmtlogo_no_wordmark to test_pygmtlogo_wordmark_none
seisman e5f0af1
Merge branch 'pygmtlogo-parameterize' into pygmtlogo-font
seisman 089d334
Remove one unused dvc file
seisman 645ec10
Fix a typo
seisman 678dabe
Merge branch 'pygmtlogo' into pygmtlogo-font
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
pygmt/tests/baseline/test_pygmtlogo_design_circle-horizontal.png.dvc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| outs: | ||
| - md5: 8924c7d80afcc92df4e77e6856b553a4 | ||
| size: 336254 | ||
| - md5: 44a9a200fbac4c868b69cb1c13e6dfc5 | ||
| size: 320394 | ||
| hash: md5 | ||
| path: test_pygmtlogo_design_circle-horizontal.png |
5 changes: 5 additions & 0 deletions
5
pygmt/tests/baseline/test_pygmtlogo_wordmark_horizontal_circle.png.dvc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| outs: | ||
| - md5: 9715eb13bec45201818d701970a529c8 | ||
| size: 63949 | ||
| hash: md5 | ||
| path: test_pygmtlogo_wordmark_horizontal_circle.png |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we can calculate the exact width of the wordmark "PyGMT" and by this the exact value of x_max for the logo with horizontal wordmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, but since the values in the
regionparameter do not affect the appearance of the logos, I don’t think it’s necessary to perform additional calculations that rely on more magic numbers.