Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Commit 0370cd8 (2018) compared the longitude separation of two consecutive points against half the -R width instead of 180 degrees, so in regions 90-360 degrees wide any segment longer than half the region was treated as a map jump and drawn the other way (test psxy/nojump, bottom panel). For 360-degree regions the threshold was already 180. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Esteban82
changed the title
The 2015 baseline has the old degree symbol and hyphen-minus in the axis annotations (changed in 586758f, 2018-12-06), so it fails on every platform even though the lines are now drawn correctly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)DetailsAdded imagesModified images
Report last updated at commit be217a2 |
Member
Author
|
Baseline regenerated: the 2015 one has the old degree symbol and hyphen-minus in the axis annotations (changed in #206), so it failed on all platforms even though the lines now match. Lines are unchanged; only the annotation text differs. |
Member
|
Honestly, I find the change dangerous. Paul has made like it was for a reason. Right, it leads to failures in some cases but what about others? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 0370cd8 (2018) made
gmtmap_jump_xcompare the longitude separation of two points against half the-Rwidth instead of 180°. In regions 90-360° wide, any segment longer than half the region was treated as a map jump and drawn the other way (like inpsxy/nojump, bottom panel). This restores the 180° test; 360° regions are unchanged since their threshold was already 180.Tested with:
printf "115 -20\n115 15\n195 15\n" | gmt psxy -R110/215/-27/20 -JM6i -A -W5p -png nojumpWithout this fix:
With this fix:
Before: the 80° side is split in two pieces at the map edges. After: one straight line.
The first commit drops
GMT_KNOWN_FAILUREfrompsxy/nojumpwith the 2015 baseline untouched. The line geometry now matches that baseline pixel for pixel, but the test is expected to still fail on its axis annotations (degree symbol and minus sign changed in 586758f). A follow-up will drop the annotations and regenerate the baseline.Written with Claude Opus 5.5 (effort: default).