Skip to content

Fix test_cm4 by pinning the Dst index and drop its known-failure flag - #9275

Open
Esteban82 wants to merge 1 commit into
masterfrom
fix-test-cm4
Open

Esteban82 wants to merge 1 commit into
masterfrom
fix-test-cm4

Conversation

@Esteban82

Copy link
Copy Markdown
Member

Mag_pri/Mag_ind in test_cm4 stopped matching the Fortran reference when the Dst file was revised in #627. Pin the old Dst with -D-8 (works since #9270) and drop GMT_KNOWN_FAILURE; test_cm4.dat is unchanged.

To be verified by CI.

Model: Claude Sonnet 5.5, low effort; reviewed locally with Opus.

The hourly Dst values in share/mgd77/Dst_all.wdc were revised in #627 (+1 nT
around 2000-02-01), which shifted Mag_pri and Mag_ind away from the Fortran
reference. The code is unchanged and still reproduces the Fortran output with
the old Dst; pass the old value with -D-8 so the test no longer depends on the
data file.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Esteban82 Esteban82 added the maintenance Boring but important stuff for the core devs label Oct 20, 2026
@Esteban82

Copy link
Copy Markdown
Member Author

test/mgd77/test_cm4.sh passes on Linux, macOS and Windows in CI. This can be approved.

@Esteban82
Esteban82 requested review from joa-quim and seisman October 20, 2026 02:38

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant