Gecode 7 breaking changes

.clang-format

@@ -0,0 +1,17 @@
+# Use clang-format 22; see docs/code-style.md.
+BasedOnStyle: LLVM
+IndentWidth: 4
+ContinuationIndentWidth: 4
+AccessModifierOffset: -4
+ColumnLimit: 120
+NamespaceIndentation: All
+CompactNamespaces: true
+BreakBeforeBraces: Attach
+BreakAfterReturnType: AllDefinitions
+PointerAlignment: Left
+ReferenceAlignment: Left
+SortIncludes: Never
+ReflowComments: IndentOnly
+AllowShortFunctionsOnASingleLine: Empty
+BreakTemplateDeclarations: Yes
+AttributeMacros: [forceinline]

.clang-tidy

@@ -0,0 +1,125 @@
+# Use clang-tidy 22. Each group below is enabled as a whole, and a line that
+# starts with a minus excludes a check that was tried and does not fit. The
+# reasons are in docs/code-style.md. Checks from other groups are named one by
+# one, because most of those groups are aliases of checks enabled here.
+Checks: >-
+  -*,
+  clang-analyzer-core.*,
+  clang-analyzer-cplusplus.*,
+  -clang-analyzer-cplusplus.NewDeleteLeaks,
+  clang-analyzer-deadcode.*,
+  clang-analyzer-nullability.*,
+  clang-analyzer-optin.*,
+  -clang-analyzer-optin.core.EnumCastOutOfRange,
+  -clang-analyzer-optin.cplusplus.UninitializedObject,
+  -clang-analyzer-optin.performance.Padding,
+  clang-analyzer-security.*,
+  -clang-analyzer-security.ArrayBound,
+  clang-analyzer-unix.*,
+  -clang-analyzer-unix.Malloc,
+  clang-analyzer-valist.*,
+  cert-err33-c,
+  google-default-arguments,
+  cppcoreguidelines-no-malloc,
+  cppcoreguidelines-rvalue-reference-param-not-moved,
+  cppcoreguidelines-misleading-capture-default-by-value,
+  cppcoreguidelines-missing-std-forward,
+  google-build-explicit-make-pair,
+  google-global-names-in-headers,
+  hicpp-exception-baseclass,
+  bugprone-*,
+  -bugprone-branch-clone,
+  -bugprone-derived-method-shadowing-base-method,
+  -bugprone-easily-swappable-parameters,
+  -bugprone-implicit-widening-of-multiplication-result,
+  -bugprone-inc-dec-in-conditions,
+  -bugprone-macro-parentheses,
+  -bugprone-multi-level-implicit-pointer-conversion,
+  -bugprone-narrowing-conversions,
+  -bugprone-signed-char-misuse,
+  -bugprone-switch-missing-default-case,
+  -bugprone-throwing-static-initialization,
+  -bugprone-unchecked-string-to-number-conversion,
+  concurrency-*,
+  -concurrency-mt-unsafe,
+  misc-*,
+  -misc-confusable-identifiers,
+  -misc-const-correctness,
+  -misc-header-include-cycle,
+  -misc-include-cleaner,
+  -misc-multiple-inheritance,
+  -misc-new-delete-overloads,
+  -misc-no-recursion,
+  -misc-non-private-member-variables-in-classes,
+  -misc-static-assert,
+  -misc-use-anonymous-namespace,
+  modernize-*,
+  -modernize-avoid-c-arrays,
+  -modernize-pass-by-value,
+  -modernize-return-braced-init-list,
+  -modernize-use-auto,
+  -modernize-use-default-member-init,
+  -modernize-use-designated-initializers,
+  -modernize-use-nodiscard,
+  -modernize-use-std-numbers,
+  -modernize-use-trailing-return-type,
+  performance-*,
+  -performance-enum-size,
+  -performance-no-int-to-ptr,
+  portability-*,
+  -portability-template-virtual-member-function,
+  readability-*,
+  -readability-avoid-nested-conditional-operator,
+  -readability-braces-around-statements,
+  -readability-convert-member-functions-to-static,
+  -readability-function-cognitive-complexity,
+  -readability-function-size,
+  -readability-identifier-length,
+  -readability-implicit-bool-conversion,
+  -readability-isolate-declaration,
+  -readability-magic-numbers,
+  -readability-make-member-function-const,
+  -readability-math-missing-parentheses,
+  -readability-named-parameter,
+  -readability-redundant-declaration,
+  -readability-use-anyofallof
+WarningsAsErrors: '*'
+HeaderFilterRegex: '(gecode|test|examples|tools)/'
+ExcludeHeaderFilterRegex: 'gecode/flatzinc/(parser\.tab\.(cpp|hpp)|lexer\.yy\.cpp)$'
+FormatStyle: file
+
+CheckOptions:
+  # Explicit discards document intentional ownership handoffs.
+  bugprone-unused-return-value.AllowCastToVoid: true
+  bugprone-empty-catch.IgnoreCatchWithKeywords: 'Expected;Ignored'
+  # main reports nothing useful by catching, and the move members this
+  # reports are implicit ones of value types and lambdas.
+  bugprone-exception-escape.CheckMain: false
+  bugprone-exception-escape.CheckMoveMemberFunctions: false
+  # glibc needs this feature macro defined before any system header.
+  bugprone-reserved-identifier.AllowedIdentifiers: '_GNU_SOURCE'
+  cert-err33-c.AllowCastToVoid: true
+  # Checking functions finds the real cases; classes and test registration
+  # objects in .cpp files would only need wrapping in anonymous namespaces.
+  misc-use-internal-linkage.AnalyzeTypes: false
+  misc-use-internal-linkage.AnalyzeVariables: false
+  # De Morgan rewrites do not make these conditions easier to read.
+  readability-simplify-boolean-expr.SimplifyDeMorgan: false
+  # Sites without a fix-it declare variables in the condition.
+  readability-else-after-return.WarnOnUnfixable: false
+  readability-identifier-naming.FunctionCase: lower_case
+  readability-identifier-naming.MethodCase: lower_case
+  readability-identifier-naming.VariableCase: lower_case
+  readability-identifier-naming.MemberCase: lower_case
+  readability-identifier-naming.ParameterCase: lower_case
+  readability-identifier-naming.EnumConstantCase: UPPER_CASE
+  readability-identifier-naming.ConstantCase: lower_case
+  # Constants and functions standing for constant values, such as
+  # ME_INT_VAL, ES_SUBSUMED, and INT_VAR_SIZE_MIN, may use UPPER_CASE.
+  readability-identifier-naming.ConstantIgnoredRegexp: '^(_?[a-z][a-z0-9_]*|[a-z][a-z0-9_]*_|[A-Z][A-Z0-9_]*)$'
+  readability-identifier-naming.FunctionIgnoredRegexp: '^(_[a-z][a-z0-9_]*|[A-Z][A-Z0-9_]*)$'
+  readability-identifier-naming.MethodIgnoredRegexp: '^(_[a-z][a-z0-9_]*|[A-Z][A-Z0-9_]*)$'
+  readability-identifier-naming.VariableIgnoredRegexp: '^(_[a-z][a-z0-9_]*|[a-z][a-z0-9_]*_)$'
+  readability-identifier-naming.MemberIgnoredRegexp: '^(_[a-z][a-z0-9_]*|[a-z][a-z0-9_]*_)$'
+  readability-identifier-naming.ParameterIgnoredRegexp: '^(_[a-z][a-z0-9_]*|[a-z][a-z0-9_]*_)$'
+  readability-identifier-naming.EnumConstantIgnoredRegexp: '^[A-Z][A-Z0-9_]*_$'

.editorconfig

@@ -1,10 +1,5 @@
-# EditorConfig file for Gecode
-# See https://EditorConfig.org for more information about the .editorconfig format
-
-# top-most EditorConfig file
 root = true
 
-# Unix-style newlines with a newline ending every file
 [*]
 end_of_line = lf
 insert_final_newline = true
@@ -13,6 +8,12 @@ charset = utf-8
 indent_style = space
 indent_size = 2
 
-# Makefiles need to use Tab indentation
-[Makefile*]
-indent_style = tab
+[*.{c,cc,cpp,cxx,h,hh,hpp,hxx,lxx,yxx,vis}]
+indent_size = 4
+max_line_length = 120
+
+[*.py]
+indent_size = 4
+
+[{CMakeLists.txt,*.cmake,*.yml,*.yaml}]
+indent_size = 2

.github/ci/32-bit-linkage-smoke.sh

@@ -43,7 +43,7 @@ EOF
 cat > "$consumer_dir/main.cpp" <<'EOF'
 #include <gecode/search.hh>
 
-int main(void) {
+int main() {
   Gecode::Search::Statistics statistics;
   Gecode::Search::Options options;
 

.github/ci/cmake-consumer-smoke-msys2.sh

@@ -23,7 +23,7 @@ cat > "$work/main.cpp" <<'EOF'
 #include <gecode/int.hh>
 #include <gecode/support/config.hpp>
 
-int main(void) {
+int main() {
   Gecode::IntArgs values(1);
   values[0] = 0;
   return values[0];

.github/ci/cmake-consumer-smoke-vcpkg.ps1

@@ -49,7 +49,7 @@ target_link_libraries(consumer_a PRIVATE Gecode::gecode)
 '@ | Set-Content -Encoding utf8 (Join-Path $work "a\CMakeLists.txt")
 @'
 #include <gecode/support/config.hpp>
-int main(void) { return 0; }
+int main() { return 0; }
 '@ | Set-Content -Encoding utf8 (Join-Path $work "a\main.cpp")
 
 @'
@@ -61,7 +61,7 @@ target_link_libraries(consumer_b PRIVATE Gecode::gecodedriver)
 '@ | Set-Content -Encoding utf8 (Join-Path $work "b\CMakeLists.txt")
 @'
 #include <gecode/driver.hh>
-int main(void) {
+int main() {
   Gecode::Options options("consumer_b");
   return options.model();
 }
@@ -103,7 +103,7 @@ target_link_libraries(consumer_d PRIVATE Gecode::gecodefloat)
 #error "Expected installed Gecode package to enable MPFR"
 #endif
 #include <gecode/float.hh>
-int main(void) {
+int main() {
   Gecode::Float::Rounding rounding;
   return rounding.exp_down(1.0) > 0.0 ? 0 : 1;
 }

.github/ci/cmake-consumer-smoke.ps1

@@ -34,7 +34,7 @@ target_link_libraries(consumer_a PRIVATE Gecode::gecode)
 '@ | Set-Content -Encoding utf8 (Join-Path $work "a\CMakeLists.txt")
 @'
 #include <gecode/support/config.hpp>
-int main(void) { return 0; }
+int main() { return 0; }
 '@ | Set-Content -Encoding utf8 (Join-Path $work "a\main.cpp")
 
 @'
@@ -46,7 +46,7 @@ target_link_libraries(consumer_b PRIVATE Gecode::gecodedriver)
 '@ | Set-Content -Encoding utf8 (Join-Path $work "b\CMakeLists.txt")
 @'
 #include <gecode/driver.hh>
-int main(void) {
+int main() {
   Gecode::Options options("consumer_b");
   return options.model();
 }
@@ -125,15 +125,13 @@ find_library(GECODE_SUPPORT_LIBRARY
   NO_DEFAULT_PATH
   REQUIRED)
 add_executable(manual_consumer main.cpp)
+target_compile_features(manual_consumer PRIVATE cxx_std_23)
 target_include_directories(manual_consumer PRIVATE "${GECODE_INCLUDE_DIR}")
 target_link_libraries(manual_consumer PRIVATE "${GECODE_SUPPORT_LIBRARY}")
 '@ | Set-Content -Encoding utf8 (Join-Path $work "manual\CMakeLists.txt")
 @'
 #include <gecode/support.hh>
-#ifndef GECODE_NO_AUTOLINK
-#error "CMake-installed headers must disable legacy MSVC auto-linking"
-#endif
-int main(void) {
+int main() {
   (void) Gecode::Support::hwrnd();
   return 0;
 }