add version info to gui#636
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR propagates build/version metadata from the native components (service/kernel/UI host) into the CEF-rendered frontend and surfaces it in a new “About” settings page, addressing #442.
Changes:
- Add product/file/build toolchain version macros to native build configurations and return them via new/extended OpenSession responses.
- Introduce a new CEF async endpoint (
getAppInfo) to aggregate version/build/runtime information for the UI. - Add a new Vue “About” page, route, and API typing to display the collected metadata.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| IntelPresentMon/PresentMonService/PresentMonService.vcxproj | Defines PM_VER_PRODUCT_STR for service builds so version can be surfaced. |
| IntelPresentMon/PresentMonService/acts/OpenSession.h | Extends service OpenSession response with build time + product version; switches to long build hash. |
| IntelPresentMon/PresentMonMiddleware/ActionClient.h | Updates build-id handshake to use long hash consistently. |
| IntelPresentMon/KernelProcess/KernelProcess.vcxproj | Defines version macros and PM_KERNEL_PROCESS_BUILD to enable kernel-side reporting. |
| IntelPresentMon/KernelProcess/kact/OpenSession.h | Extends kernel OpenSession response with build/version and middleware API version. |
| IntelPresentMon/AppCef/source/util/AsyncEndpointCollection.cpp | Registers the new GetAppInfo async endpoint; simplifies duplicate-key check. |
| IntelPresentMon/AppCef/source/util/async/GetAppInfo.h | New endpoint that assembles app/service/runtime/toolchain/version details into a CEF object. |
| IntelPresentMon/AppCef/source/util/ActionClientServer.h | Stores and exposes service/kernel build/version fields on CefClient. |
| IntelPresentMon/AppCef/source/util/ActionClientServer.cpp | Populates cached version/build fields from kernel OpenSession response. |
| IntelPresentMon/AppCef/source/DataBindAccessor.h | Adds kernel wrapper accessor used by GetAppInfo. |
| IntelPresentMon/AppCef/source/DataBindAccessor.cpp | Implements kernel wrapper accessor used by GetAppInfo. |
| IntelPresentMon/AppCef/ipm-ui-vue/src/views/AboutConfigView.vue | New About page UI rendering version/build/runtime info. |
| IntelPresentMon/AppCef/ipm-ui-vue/src/router/index.ts | Adds /about route. |
| IntelPresentMon/AppCef/ipm-ui-vue/src/core/app-info.ts | Adds AppInfo TypeScript interface for the new endpoint payload. |
| IntelPresentMon/AppCef/ipm-ui-vue/src/core/api.ts | Adds Api.getAppInfo() wrapper. |
| IntelPresentMon/AppCef/ipm-ui-vue/src/App.vue | Adds About entry to settings navigation and settings-route detection. |
| IntelPresentMon/AppCef/CefNano.vcxproj | Adds version/build macros for the UI host and includes the new endpoint header. |
| AGENTS.md | Updates contributor workflow guidance around CRLF normalization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
markgalvan-intel
approved these changes
Jun 3, 2026
Collaborator
markgalvan-intel
left a comment
There was a problem hiding this comment.
Excellent. The additional version information is great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate various helpful version/build information to frontend and surface on a new About page.
closes #442