optimize ChunkProviderSuperPatcher: don't create ClassNode in shouldTransformClass#288
Open
danyadev wants to merge 1 commit into
Open
optimize ChunkProviderSuperPatcher: don't create ClassNode in shouldTransformClass#288danyadev wants to merge 1 commit into
danyadev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on FalsePattern/FalsePatternLib/pull/50
Will need to bump both compile and runtime dependency version after it's released
Now falsepattern takes only 3% of GTNH transforming time during client load, or only 150ms, which is 10 times less compared to initial measure:

For a reference, after only the first FalsePatternLib PR
MergeableTurboTransformer.transformtook 12.4ms for this particular class instead of 1ms nowInitial behavior: create a ClassNode, walk over all methods, then for every method walk over all instructions and search for
CLASS_Chunkowner +METHOD_getBiomeArrayname +()[BdescriptorNew behavior: first search for
CLASS_Chunkin constant pool entries, then (if there's at least one match) search forMETHOD_getBiomeArrayin constant pool entriesIt's a bit broader because we don't search for a descriptor, and method owner & method name are not necessarily connected to each other anymore, but potentially a bit larger subset of matched classes is still infinitely better than creating a ClassNode for every single class