Embedded forms should not have h1 headings - #2123
Draft
sanason wants to merge 6 commits into
Draft
Conversation
sanason
commented
Aug 24, 2026
| @@ -9,16 +9,98 @@ | |||
|
|
|||
Member
Author
There was a problem hiding this comment.
The example page got spiffed up a bit but has no fundamental changes. This is the page where you can preview how your embedded form will look when it is embedded on a webpage.
sanason
commented
Aug 25, 2026
| @@ -1,26 +1,27 @@ | |||
| <header> | |||
Member
Author
There was a problem hiding this comment.
In addition to making heading level configurable, I also moved the logo div outside of the heading tag, since div inside heading is not valid html.
sanason
marked this pull request as draft
August 25, 2026 17:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.