Support struct-backed type#132
Merged
piotrAMD merged 2 commits intoGPUOpen-Drivers:devfrom Oct 22, 2025
Merged
Conversation
Support struct-backed type, which is a custom struct type where:
1. the first field is a sentinel of integer type
2. each integer argument N passed during constructing the type is treated
as an unsigned int encoded as a struct field:
- intN (integer with N bit width) for positive N (up to MAX_INT_BITS)
- empty structure for N == 0
For example
StructBackedType::get(ctx, 1, 0, 2)
gets encoded as
%sb_1.0.2. = type { i41, i1, {}, i2 }
Co-authored-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
nhaehnle
reviewed
Oct 20, 2025
Member
nhaehnle
left a comment
nhaehnle
left a comment
There was a problem hiding this comment.
Generally LGTM, but I do have some nits.
- Remove struct prefix - Remove underscores
Contributor
Author
|
Thanks. Struct prefix and underscores removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support struct-backed type, which is a custom struct type where:
as an unsigned int encoded as a struct field:
For example
StructBackedType::get(ctx, 1, 0, 2)
gets encoded as
%sb_1.0.2. = type { i41, i1, {}, i2 }
Co-authored-by: Nicolai Hähnle nicolai.haehnle@amd.com