Merged
Conversation
move from essd/ to main directory, add gitpython as a dependency
- test whether new/updated csv files have correct columns - test whether all geopackage files (a) exist, and (b) have the correct columns
- re-name test_column_names -> test_columns - add list of rgi regions rather than parsing filenames - add test to compare lake_cat values in csv files and geopackage files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes
environment.ymlfor running tests locallyscripts/test_submission.py, which checks that all new/changed CSV files have the required columns; checks that geopackage files exist for all regions and that they have the correct columns; checks that the geopackagelake_catattributes match what is found in the respectivedataset/csvfiles.