feat: add a "check internal tag" action to mesh-doctor#236
Open
feat: add a "check internal tag" action to mesh-doctor#236
Conversation
added 2 commits
February 24, 2026 17:44
jafranc
reviewed
Feb 27, 2026
| help="[string]: Output CSV file for problematic elements (optional)" ) | ||
|
|
||
| p.add_argument( '--' + __NULL_TAG_VALUE, | ||
| type=float, |
Contributor
Author
There was a problem hiding this comment.
Just to be consistent with the original vtu which stores FaultMask as a float rather than a int.
But I agree all tags should be int.
Contributor
Author
There was a problem hiding this comment.
The code is now handling all tags as int.
| type=str, | ||
| metavar=", ".join( __DATA_MODE_VALUES ), | ||
| default=__DATA_MODE_DEFAULT, | ||
| help='[string]: For ".vtu" output format, the data mode can be binary or ascii. Defaults to binary.' ) |
Collaborator
There was a problem hiding this comment.
is there any value at this point in ascii ?
Contributor
Author
There was a problem hiding this comment.
was mimicking other action. Will force binary and change orphan2d as well.
Comment on lines
252
to
258
| # Collect bad elements | ||
| for elem in elementsByNeighbors[ 0 ]: | ||
| allBadElements.append( elem ) | ||
| for elem in elementsByNeighbors[ 1 ]: | ||
| allBadElements.append( elem ) | ||
| for elem in elementsByNeighbors[ 'other' ]: | ||
| allBadElements.append( elem ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Collect bad elements | |
| for elem in elementsByNeighbors[ 0 ]: | |
| allBadElements.append( elem ) | |
| for elem in elementsByNeighbors[ 1 ]: | |
| allBadElements.append( elem ) | |
| for elem in elementsByNeighbors[ 'other' ]: | |
| allBadElements.append( elem ) | |
| # Collect bad elements | |
| allBadElements.extend( elementsByNeighbors[0] ) | |
| allBadElements.extend( elementsByNeighbors[1] ) | |
| allBadElements.extend( elementsByNeighbors['other'] ) |
Contributor
Author
There was a problem hiding this comment.
thanks, suggestion is now integrated
Co-authored-by: Jacques Franc <49998870+jafranc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
mesh-doctoraction to verify that tagged 2D elements are internal (i.e., have exactly 2 volume neighbors):Usage