Repository navigation
Test the 3D island with its effects, shadows and full resolution - #1113
Merged
Merged
Conversation
The gameplay tests of the 3D island disabled the ambient occlusion, the depth of field, the bloom and the shadows, lowered the resolution and hid the grass to run faster in the software renderer. Stepped frames are not drawn, so this only changed the screenshots, which then did not show the game as it is played - and left the rendering of these effects untested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GFZna1tBkWVDbpAbTNnXpr
Contributor
Preview the game(s) changed or added in this Pull RequestThis is an automatic message displaying links to the games in this PR - double check the JSON in case of doubt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gameplay tests of the 3D island disabled the ambient occlusion, the depth of field, the bloom and the shadows, lowered the game resolution (down to 160x90) and hid the grass, to run faster in the software renderer. Stepped frames are not drawn, so this only changed the screenshots: they did not show the game as it is played, and the rendering of these effects was never exercised by the tests (the gameplay harness guide also asks to never do this).
These lines are removed from the 11 tests (52 lines, nothing else changed). The 60s timeout of the two brush tests is kept.
Verification
Ran the 11 tests with the Linux portable build of GDevelop
master(5.6.286), under xvfb with the software renderer (SwiftShader):Also ran with a build including 4ian/GDevelop#9337, where all 11 also pass. That PR fixes ambient occlusion and depth of field being slow on Windows since 5.6.286, which these tests could not have caught while the effects were disabled.
Generated by Claude Code