Godot addon: Prevent turning on incompatible reorder code and safe mode simultaneously#296
Merged
Merged
Conversation
|
There is set_as_internal for ProjectSettings that should make a field invisible to users. |
Contributor
Author
|
Thanks, but unfortunately that's not available to the editor settings, which is a different singleton with a different API. It's a minor thing, it's not something super important; we can derive needed data migrations from previous state. |
NathanLovato
force-pushed
the
nathan/addon-format-modes
branch
from
July 24, 2026 08:07
196cf5e to
0664dfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #286
One of the users reported that they could not format their code in Godot and the issue had to do with format mode and reorder code being both turned on but they're actually incompatible at the moment.
This changes the editor settings and adds a little piece of migration code to turn it into a drop-down menu.
We don't seem to have a way to track the version of the editor settings for migrations if anyone has a suggestion as how we could store some hidden metadata in the editor settings I'm all ears.