Skip to content

Linter: no-else-return failing to detect return in this case #339

Description

@NathanLovato

There is a bug in your linter that causes it to not recognize that the designated block can fail the if statement and skip the return statement:

  1. The incorrect warning is:
    “WARNING on line 75 (no-else-return)
    Unnecessary 'else' after 'if'/'elif' blocks that end with 'return'”

  2. The code that triggered this error is:
    ...
    #Return false if vector_angle falls between start_arc and end_arc.
    #This will ensure that weapons can only fire within their designated arcs.
    if end_arc > start_arc:
    if vector_angle > end_arc or vector_angle < start_arc:
    return false
    else:
    if vector_angle > end_arc and vector_angle < start_arc:
    return false

    #Ensure target is within range
    if vector_to_target.length() > ability_range:
    return false
    else:
    return true

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions