Repository navigation
fix(ui): refine agent creation and session navigation - #3590
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refine Agent creation and session navigation across the Web UI:
Type and Areas
Type: UI/UX, bug fix
Areas: Web UI, design system, Rust Agent tool catalog
Motivation / Impact
Users can create and configure Agents using visible names, return to recent workspace conversations, and navigate menus without stray overflow hints. Existing Agent IDs and host APIs remain compatible; the session-history field is optional for older tabs.
Verification
AI-assisted; tested with focused automated checks. All checks below passed:
pnpm run check:webpnpm run fmt:rscargo test --locked -p openbitfun-core --no-default-features --features agent-runtime,git --lib agentic::tools::implementations::task::tests— 75 passednode --test design-system/packages/ui/tests/icon.test.mjs design-system/packages/ui/tests/icon-slots.test.mjs design-system/packages/ui/tests/tab-group.test.mjs— 31 passed after the design-system build performed bycheck:webpnpm run i18n:audit— zero warningspnpm run theme:color-audit:allpnpm run motion:audit— inventory reviewed; existing PortForwardDialog inventory item is outside this changepnpm --dir src/web-ui run icons:checknode scripts/check-git-object-sizes.mjs --base origin/main --head HEADgit diff --cached --checkFocused Web UI command — 36 files, 495 tests passed
pnpm --dir src/web-ui exec node scripts/run-vitest.mjs run --maxWorkers=50% \ src/app/components/NavPanel/sections/workspaces/AssistantSessionHistory.test.tsx \ src/app/components/NavPanel/sections/workspaces/WorkspaceListSectionLayout.test.ts \ src/app/components/NavPanel/sections/workspaces/assistantSessionPreferences.test.ts \ src/app/components/SceneBar/SceneBar.test.tsx \ src/app/hooks/useSessionTabLabels.test.tsx \ src/app/scenes/agents/AgentsScene.test.tsx \ src/app/scenes/agents/components/CreateAgentDialog.test.tsx \ src/app/scenes/agents/components/CreateAgentPage.presentation.test.ts \ src/app/scenes/agents/components/ToolGroupPicker.test.tsx \ src/app/scenes/agents/components/subagentEditorUtils.test.ts \ src/app/scenes/agents/components/suggestAgentId.test.ts \ src/app/scenes/personal-overview/PersonalOverviewScene.actions.test.tsx \ src/app/scenes/session/AuxPaneEmptyState.test.tsx \ src/app/scenes/settings/pages/ai/MemorySettingsSection.presentation.test.ts \ src/app/scenes/settings/pages/application/MessageSendingSettingsSection.test.tsx \ src/app/scenes/settings/pages/shared/ApplicationSettings.presentation.test.ts \ src/app/services/sessionSceneLifecycle.test.ts \ src/app/startup/startupPreload.test.ts \ src/app/stores/sceneStore.test.ts \ src/flow_chat/components/ModelSelectorAcpMode.test.tsx \ src/flow_chat/components/ModelSelectorExternal.test.tsx \ src/flow_chat/components/ModelSelectorProviderLevels.test.tsx \ src/flow_chat/services/sessionActivation.test.ts \ src/flow_chat/services/storeSync.test.ts \ src/infrastructure/appearance/registry/AppearanceRegistry.test.ts \ src/infrastructure/config/components/AcpAgentsConfig.test.tsx \ src/infrastructure/config/components/AppearancePackageConfigSection.test.tsx \ src/infrastructure/config/components/McpToolsConfig.presentation.test.ts \ src/infrastructure/config/components/McpToolsConfig.test.tsx \ src/infrastructure/config/components/common/SettingsControlSizing.test.ts \ src/infrastructure/design-system/IconUsageIntegration.test.tsx \ src/shared/ui/MenuComposition.contract.test.ts \ src/shared/ui/MenuPopover.test.tsx \ src/shared/ui/OverflowText.test.tsx \ src/tools/git/components/BranchQuickSwitch.test.tsx \ src/tools/git/components/branchSwitchFailure.test.tsReviewer Notes
Local DOM/store tests simulate SSH workspace identities and Peer device switches; no live Remote Workspace, Remote Control, Peer Device, or Detached Dispatch scenario was exercised. Browser/computer-control verification was omitted per the user's instruction.
Checklist