Repository navigation
fix(session-import): show discovery errors as notifications - #3571
Merged
Merged
Conversation
kev1n77
force-pushed
the
fmy/bugfix
branch
4 times, most recently
from
October 28, 2026 03:57
059d8e8 to
fb1c35e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cursor and other external session discovery failures now appear as separate transient notifications instead of a persistent warning occupying the session list.
Type and Areas
Type: Bug fix / UI/UX
Areas: Rust core, Web UI, i18n
Motivation / Impact
External records that cannot be read and records without an unambiguous workspace match are different conditions, but the session list previously combined them in one long-lived alert. The host now sends structured diagnostic categories, and the Web UI localizes and displays each category as a deduplicated warning notification. Existing warning fields remain available for older hosts.
Verification
cargo test --locked -p openbitfun-core --no-default-features --features external-sources,git,product-search --lib external_session_import::— passedcargo test --locked -p openbitfun-services-core --no-default-features --features local-storage --lib session::page::tests— 11 passedpnpm --dir src/web-ui run test:run src/app/components/NavPanel/sections/sessions/useWorkspaceSessionDiscovery.test.tsx src/app/components/NavPanel/sections/sessions/SessionsSectionLayout.test.ts src/infrastructure/api/service-api/SessionAPI.test.ts— 37 passedpnpm run type-check:web— passedpnpm run i18n:audit— passedgit diff --check— passedReviewer Notes