fix: preserve remote session identity across session restore paths#1319
Closed
wsp1911 wants to merge 1 commit into
Closed
fix: preserve remote session identity across session restore paths#1319wsp1911 wants to merge 1 commit into
wsp1911 wants to merge 1 commit into
Conversation
- remove legacy auto-memory prompt injection and workspace memory file context - move AGENTS/CLAUDE instruction loading into a standalone instruction_context service - drop workspace_memory_files from runtime contracts, custom agent serialization, and UI config - remove obsolete memory storage path exposure from runtime layout and desktop storage API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve remote workspace identity across session-targeted agent flows and restore paths.
Fixes #
Type and Areas
Type:
bug fix / regression fix
Areas:
Rust core, desktop/Tauri, CLI, runtime ports, remote connect, web UI tests
Motivation / Impact
Remote sessions could lose their SSH identity when restored or queued through some internal paths, causing session history, cron/session tools,
/init, manual compaction, fork context capture, or remote dialog turns to resolve against the wrong local/slugged storage path.This PR makes remote session identity explicit across session workspace bindings, scheduler submissions, cron/session tools, remote dialog submissions, and persistence/session listing paths. Remote sessions now restore from resolved session storage directories, while logical workspace paths remain separate for tools and display.
It also updates the startup contract test to match the renamed thread-goal storage helper while preserving the no-restore read-only contract.
Verification
pnpm run fmt:rscargo test -p bitfun-core workspace_identity_ -- --nocapturecargo check -p bitfun-corepnpm --dir src/web-ui run test:run src/app/startup/startupPerformanceContract.test.tscargo check -p bitfun-desktopgit diff --checkReviewer Notes
The main compatibility-sensitive change is the distinction between logical workspace paths and final on-disk session storage directories. Remote workspaces should continue to expose remote logical paths to tools/UI, but persistence and restore paths should use the resolved SSH mirror session directory.
Unresolved remote sessions intentionally stay under the dedicated unresolved remote session tree instead of falling back to local project slug storage.
Checklist