Skip to content

refactor: use typed primary model facts#1317

Open
wgqqqqq wants to merge 2 commits into
GCWing:mainfrom
wgqqqqq:codex/primary-model-facts-context
Open

refactor: use typed primary model facts#1317
wgqqqqq wants to merge 2 commits into
GCWing:mainfrom
wgqqqqq:codex/primary-model-facts-context

Conversation

@wgqqqqq

@wgqqqqq wgqqqqq commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add PrimaryModelFacts as the typed per-turn primary model snapshot
  • pass the snapshot through manifest generation, prompt scaffold, round execution, and ToolUseContext
  • remove primary-model facts from tool custom_data legacy projection and migrate view_image/computer_use to typed accessors
  • document the design and logging expectations

Verification

  • pnpm run fmt:rs
  • git diff --check
  • cargo check -p bitfun-core
  • cargo test -p tool-runtime context::tests -- --nocapture
  • cargo test -p bitfun-core tool_context_runtime -- --nocapture
  • cargo test -p bitfun-core computer_use -- --nocapture
  • cargo test -p bitfun-core view_image -- --nocapture

@wgqqqqq wgqqqqq force-pushed the codex/primary-model-facts-context branch from 8d92e70 to b258604 Compare June 26, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant