fix triton token2wav model cache thread unsafety#1622
Merged
aluminumbox merged 3 commits intoDec 30, 2025
Conversation
This reverts commit cd26dd1.
- Since all token2wav requests within a single cosyvoice2 request must share the same request_id, modify the logic so that a new request_id is generated only if it does not already exist, and ensure that the same request_id is sent consistently.
yuekaizhang
approved these changes
Nov 3, 2025
Contributor
|
@GoyoUijin Many thanks. @aluminumbox Would you mind helping merge the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user does not explicitly specify a
request_idin the Triton client, the Triton server setsrequest_id=''.In this case, different threads may write to the same key in
CosyVoice2Model.hift_cache_dictsimultaneously, causing cache data from different requests to be mixed up.When serving CosyVoice2 via Triton Server, I actually observed that the output audio from different requests got mixed.
Example
On the client side:
On the server side:
Therefore, I propose generating and using a unique
uuiddirectly on the server side, instead of relying on the user to provide arequest_id.