fix(ci): stabilize flaky shiki test and knip entry - #12
Merged
Merged
Conversation
- Mock Date.now in shiki highlighter test so CI contention can't truncate tokenization - Register smoke-cli-archive.ts as a knip entry since release workflows don't run in this fork
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Date.nowin the shiki review highlighter test and restored it withonTestFinished, so wall-clock contention in CI can no longer truncate tokenization of the fixture.smoke-cli-archive.tsto the knipentrylist, since the CLI archive smoke tool is run manually in this fork without release workflows.Why
The shiki test was flaky in CI: Shiki bounds tokenization by wall time, and under CI contention the fixture could be truncated, failing the assertion intermittently. Mocking the clock removes the variability without changing production code.
The knip change fixes a false unused-file report for the smoke tool after the fork trimmed release workflows.
Checklist