Fix: Accept all 2xx HTTP status codes as success#19
Open
alanef wants to merge 3 commits intoFreemius:masterfrom
Open
Fix: Accept all 2xx HTTP status codes as success#19alanef wants to merge 3 commits intoFreemius:masterfrom
alanef wants to merge 3 commits intoFreemius:masterfrom
Conversation
The SDK was only accepting 200 as success, but 201 (Created) and 204 (No Content) are also valid success responses, especially for POST/PUT/DELETE operations.
Add missing blank line (EOL) after Content-Type header in multipart form data. Without this, the MIME type and file content were being concatenated, causing "application/zipPK..." instead of "application/zip". This fixes the "file must be a Zip file" error when deploying to Freemius.
When downloading .zip files, set encoding: null in request options to return a Buffer instead of parsing as UTF-8 string. This prevents binary data corruption. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK was only accepting 200 as success, but 201 (Created) and 204 (No Content) are also valid success responses, especially for POST/PUT/DELETE operations.