Skip to content

Conversation

@caetano-dev
Copy link
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #4155

Description

Removes the CSS code that hides the Open New Window button when the window is small.

Screenshots

Before

Capture d’écran_2025-12-07_12-25-22

After

Capture d’écran_2025-12-07_12-35-38

Testing

  1. Reduce the window size
  2. See the the Clone Window button appears

Desktop

  • OS: Linux
  • OS Version: Ubuntu 24
  • FreeTube version: v0.23.12 Beta

Additional context

I updated the button order in TopNav.vue to place the Clone button next to the navigation arrows, similar to the large window layout.

Before, the Clone button would be positioned to the left of the Search button on smaller screens. This change does not affect large window layouts.

Let me know your thoughts on this!

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 7, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 7, 2025 15:51
@efb4f5ff-1298-471a-8973-3d47447115dc

Not sure if we should still hide it on very small screens though. @PikachuEXE @absidue thoughts?

@PikachuEXE
Copy link
Collaborator

It's from 81a571e
I dunno why it's committed, and I don't use small width windows so I have no objection (maybe you should ask mobile users

@absidue
Copy link
Member

absidue commented Dec 8, 2025

Nobody on a mobile device ever complained about it, because it doesn't make sense to have multiple windows on a mobile device, the only people that complain about it are people using tiling window managers with so many windows on screen at the same time that the window is so small that FreeTube has to fallback to the mobile UI (IIRC @efb4f5ff-1298-471a-8973-3d47447115dc opened the issue on behalf of those complaining tiling window manager users).

If this is merged it will require a change in FreeTubeAndroid to add an IS_ANDROID build guard to remove the button, as it doesn't and shouldn't work in FreeTubeAndroid (previously that change wasn't necessary as it was hidden by code that is being removed in this PR).

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Dec 8, 2025

I dunno why it's committed

I looked through the issues starting when the button was introduced until it was changed to be hidden and it doesn't address any issue. I think that Preston thought that its logical to not include it on smaller screens

(IIRC @efb4f5ff-1298-471a-8973-3d47447115dc opened the issue on behalf of those complaining tiling window manager users).

Yup thats correct

@absidue do you think that we shouldn't address this issue?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Dec 9, 2025
auto-merge was automatically disabled December 10, 2025 13:07

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 10, 2025 13:07
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Show Open New Window in small window mode

4 participants