-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Show Open New Window button in small window #8387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
Not sure if we should still hide it on very small screens though. @PikachuEXE @absidue thoughts? |
|
It's from 81a571e |
|
Nobody on a mobile device ever complained about it, because it doesn't make sense to have multiple windows on a mobile device, the only people that complain about it are people using tiling window managers with so many windows on screen at the same time that the window is so small that FreeTube has to fallback to the mobile UI (IIRC @efb4f5ff-1298-471a-8973-3d47447115dc opened the issue on behalf of those complaining tiling window manager users). If this is merged it will require a change in FreeTubeAndroid to add an |
I looked through the issues starting when the button was introduced until it was changed to be hidden and it doesn't address any issue. I think that Preston thought that its logical to not include it on smaller screens
Yup thats correct @absidue do you think that we shouldn't address this issue? |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Head branch was pushed to by a user without write access
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Pull Request Type
Related issue
Closes #4155
Description
Removes the CSS code that hides the Open New Window button when the window is small.
Screenshots
Before
After
Testing
Desktop
Additional context
I updated the button order in TopNav.vue to place the Clone button next to the navigation arrows, similar to the large window layout.
Before, the Clone button would be positioned to the left of the Search button on smaller screens. This change does not affect large window layouts.
Let me know your thoughts on this!