Dialog view state preservation #284
Open
+199
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have fixed the issue Dialog view is destroyed (state not preserved) when rotating the screen. #744 for the Notes application. I hope my contribution is correct. Let me know if I have to change something ^^
Type of change(s)
What changed and why
NewChecklistItemDialogandEditTaskDialogclasses withChecklistItemDialogFragmentthat inherits fromDialogFragment.onSaveInstanceStateto manually save/restore the text of rows. This was necessary because the dynamic rows share the same XML View ID, which confused the automatic state restoration.setFragmentResultandsetFragmentResultListenerto safely pass data back toTasksFragmentafter the fragment recreation.Tests performed
Tested on :
Before & after preview
Before :
Check the original issue #744
After :
output.mp4
Closes the following issue(s)
FossifyOrg/General-Discussion#744 for the Notes applications
Checklist
CHANGELOG.md(if applicable).