SDKS-4655: Create Central Login App Using OIDC Client#98
Merged
SteinGabriel merged 6 commits intomainfrom Mar 17, 2026
Merged
Conversation
cerebrl
reviewed
Mar 10, 2026
Contributor
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
This PR looks good. I'm going to pull this in locally and run it. If all runs well, I'll approve this PR.
cerebrl
previously approved these changes
Mar 10, 2026
Contributor
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
Worked good locally. I'm approving this PR. Nice job, @SteinGabriel.
Contributor
|
Tried the OIDC flow locally. Looks great, approving! |
vatsalparikh
previously approved these changes
Mar 12, 2026
ancheetah
requested changes
Mar 16, 2026
Contributor
ancheetah
left a comment
ancheetah
left a comment
There was a problem hiding this comment.
Sorry to come in last minute. Left some comments on CI and other setup.
ancheetah
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://pingidentity.atlassian.net/browse/SDKS-4655
Summary
This PR implements a centralized OIDC React sample and
separating embedded-login behavior into a dedicated journey sample.
What’s included
Added new app:
javascript/reactjs-todo-oidc@forgerock/oidc-clientWEB_OAUTH_CLIENTWELLKNOWN_URLREALM_PATHSCOPE/callback.html/todosoidc-login,oidc-protected-route,oidc-todo)/registerand Sign Up CTA) for OIDC sampleREADME.mdandclient/README.md) to match current behaviorRenamed existing sample:
javascript/reactjs-todo→javascript/reactjs-todo-journeyArchived vanilla centralized-login samples:
javascript/central-login-oidc→javascript/Archived/central-login-oidcjavascript/central-login-oidc-client→javascript/Archived/central-login-oidc-clientNotes
enabled.
reactjs-todohas been renamed toreactjs-todo-journey. However, it appears this is the same journey app implementation currently in feat(react-journey): add react journey app #86. If that's the case, we might want to removereactjs-todo-journeyonce that pull request is merged.