Repository navigation
Conversation
…segment is used Each route that builds its filter from a live query segment checks that the user may run that segment, on the collection whose filter carries it, whether the segment comes from the query string or the request body: listing, counting and exporting records, deleting them, associating and dissociating related records, running an action, its form hooks and its approval, and charts. Users allowed to run a segment keep every feature on it. Refs: PRD-1759 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Scra3
force-pushed
the
fix/prd-1759-check-segment-query-permission
branch
from
October 27, 2026 14:14
29ad71f to
a70ec69
Compare
Scra3
marked this pull request as ready for review
October 27, 2026 14:41
…utes Refs: PRD-1759 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…elpers using it Refs: PRD-1759 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Scra3
commented
Oct 28, 2026
Scra3
left a comment
Member
Author
There was a problem hiding this comment.
Spec (PRD-1759): conforms to the ticket's fix. 1 unvalidated decision: not final.
Explicit ids already pin the records, so the selection's live query segment is neither checked nor run, as forest-express and forest-rails do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 new issue
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes PRD-1759
Every route that builds its filter from a live query segment checks that the user may run that segment, on the collection whose filter carries it.
What changes
Users allowed to run a segment keep every feature on it: each path above has a test for the allowed user next to the one for the refused user.
Decisions
Squash message
Definition of Done
General
Security
🤖 Generated with Claude Code
Note
Check live-query segment permission on every route that uses one
Adds
AuthorizationService.assertCanExecuteLiveQuerySegment, which parses the live-query segment from the request and throws Forbidden when the user may not execute it for the collection. Removes the implicit segment check fromassertCanOnCollection, and every read and modification route now calls the explicit assertion before building filters or running queries.ActionRoute.getRecordSelectionskips the segment check and filter when a non-global action has a positive explicit ID selection.Macroscope summarized 409bce0.