Skip to content

chore: log empty running polls in debug#1626

Open
nbouliol wants to merge 4 commits into
feat/prd-407-executor-log-levelfrom
chore/log-empty-poll-debug
Open

chore: log empty running polls in debug#1626
nbouliol wants to merge 4 commits into
feat/prd-407-executor-log-levelfrom
chore/log-empty-poll-debug

Conversation

@nbouliol
Copy link
Copy Markdown
Member

@nbouliol nbouliol commented Jun 4, 2026

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Note

Log empty running polls at debug level in Runner.runPollCycle

Reduces log noise by logging 'Poll cycle completed' at Debug instead of Info when no runs are pending, dispatched, or malformed. A new private static getPollingLogLevel helper in runner.ts determines the level based on those three counts.

Macroscope summarized 86ad10d.

nbouliol and others added 4 commits June 3, 2026 17:55
…D-407]

Align Logger with @forestadmin/agent shape (function signature, capitalized
LoggerLevel) and add a minimum-level filter on the source. Default Info
preserves current behavior; CLI reads LOG_LEVEL, library consumers pass
loggerLevel in ExecutorOptions.

fixes PRD-407

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…failure [PRD-407]

- cli-core: LOG_LEVEL env var → loggerLevel (valid values, default fallback,
  empty string fallback, invalid values throw ConfigurationError)
- mcp-step-executor: when persisting formattedResponse fails, step still
  returns success and an Error log carries the enriched-save failure cause

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Jun 4, 2026

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/runner.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@nbouliol nbouliol force-pushed the feat/prd-407-executor-log-level branch from 233bda2 to 5a71569 Compare June 4, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant