Faster thumbs#172
Open
CrystalSplitter wants to merge 6 commits into
Open
Conversation
Before, we it was possible to update the item without actually dispatching to the Redux state. This fixes this, in a very convoluted way.
It still could be better, but it's a lot better than before. Now we have some rate-limitting on thumbnail extraction, so hopefully we won't get 429s.
Collaborator
Author
|
Hmm. This has a bug where thumbnails will show up as black boxes occasionally, even when we already have the thumbnails fetched and stored in the DB. Not sure why. Perhaps something to do with the thumbnail canvas caching? |
Collaborator
Author
Oh; that may have been because of network throttling I had during testing. That would make more sense. |
Much more ergonomic to use a method fetch rather than pass it as the final argument of a long method.
This is more clean up work, should not have any functional change.
Non-functional change.
This adds a number of stricter static checks, as well as fixes for thumbnail parsing with redux ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement lazy-loading for thumbnail fetching.
We give thumbnails exactly 1 second to load to prevent flashing, but after that we give up and let them load
in the background without waiting. This is implemented by keeping track of an item's
thumbnailJobs, andthen dispatching state/updating the DB on their completion.
Fixes #171.