Allow cached-img to guess image content-type#168
Merged
Conversation
CrystalSplitter
force-pushed
the
crystal/content-type
branch
from
72461b6 to
0b472b7
Compare
Some responses from opengraph embeds don't announce their content types. This is annoying, but since we are checking that this is an actual opengraph embed, we can assume it's some sort of image... probably. Example feed that the current code fails on: https://haskellforall.com/rss.xml
CrystalSplitter
force-pushed
the
crystal/content-type
branch
from
0b472b7 to
cc7094c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some responses from opengraph embeds don't announce their content types. This is annoying, but since we are checking that this is an actual opengraph embed, we can assume it's some sort of image... probably.
Example feed that the current patch code on:
https://haskellforall.com/rss.xml